Repository navigation
[sqlite3] Move MODULE_NAME def from setup.py to module.h #87610
Description
| BPO | 43444 |
|---|---|
| Nosy | @berkerpeksag, @erlend-aasland |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = <Date 2021-03-13.15:34:03.151>
created_at = <Date 2021-03-09.10:34:19.575>
labels = ['type-feature', 'library', '3.10']
title = '[sqlite3] Move MODULE_NAME def from setup.py to module.h'
updated_at = <Date 2021-03-13.15:34:03.150>
user = 'https://github.com/erlend-aasland'bugs.python.org fields:
activity = <Date 2021-03-13.15:34:03.150>
actor = 'berker.peksag'
assignee = 'none'
closed = True
closed_date = <Date 2021-03-13.15:34:03.151>
closer = 'berker.peksag'
components = ['Library (Lib)']
creation = <Date 2021-03-09.10:34:19.575>
creator = 'erlendaasland'
dependencies = []
files = []
hgrepos = []
issue_num = 43444
keywords = ['patch']
message_count = 3.0
messages = ['388344', '388623', '388624']
nosy_count = 2.0
nosy_names = ['berker.peksag', 'erlendaasland']
pr_nums = ['24801']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43444'
versions = ['Python 3.10']
Activity
erlend-aasland commentedon Mar 9, 2021
Berker, can we please move the MODULE_NAME define from setup.py to Modules/_sqlite/module.h? I'm tired of all the undeclared identifier warnings. No other module defines their MODULE_NAME in setup.py.
berkerpeksag commentedon Mar 13, 2021
New changeset 2256a28 by Erlend Egeberg Aasland in branch 'master':
bpo-43444: Move sqlite3 MODULE_NAME from setup.py to module.h (GH-24801)
2256a28
berkerpeksag commentedon Mar 13, 2021
Thank you!
only define MODULE_NAME for sqlite on python <= 3.9 (#767)