Skip to content

[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure #85848

Closed
Closed
[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure#85848
Labels
3.10 (EOL)end of life3.11only security fixesOS-windowstestsTests in the Lib/test dirtopic-asynciotype-bugAn unexpected behavior, bug, or error

Description

@aeros
aeros
opened on Sep 1, 2020
BPO 41682
Nosy @gvanrossum, @terryjreedy, @ncoghlan, @vstinner, @asvetlov, @1st1, @miss-islington, @sweeneyde, @aeros, @erlend-aasland, @sobolevn, @Fidget-Spinner, @kumaraditya303, @arhadthedev
PRs
  • bpo-41682: skip test_sendfile_close_peer_in_the_middle_of_receiving in test_asyncio #30801
  • [3.9] bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801) #30811
  • [3.10] bpo-41682: Skip unstable test_asyncio sendfile test on Windows (GH-30801) #30812
  • bpo-45382: test.pythoninfo logs more Windows versions #30817
  • bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving #30845
  • [3.10] bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) #30860
  • [3.9] bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) #30861
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = <Date 2022-01-25.17:41:06.264>
created_at = <Date 2020-09-01.01:20:55.485>
labels = ['type-bug', '3.10', '3.11', 'tests', 'OS-windows', 'expert-asyncio']
title = '[Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure'
updated_at = <Date 2022-01-25.18:03:17.384>
user = 'https://github.com/aeros'

    bugs.python.org fields:

    activity = <Date 2022-01-25.18:03:17.384>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-25.17:41:06.264>
closer = 'vstinner'
components = ['Tests', 'Windows', 'asyncio']
creation = <Date 2020-09-01.01:20:55.485>
creator = 'aeros'
dependencies = []
files = []
hgrepos = []
issue_num = 41682
keywords = ['patch']
message_count = 23.0
messages = ['376175', '376176', '391134', '392061', '396238', '396503', '399770', '402294', '404820', '408612', '411293', '411299', '411313', '411322', '411386', '411508', '411638', '411639', '411640', '411641', '411643', '411646', '411651']
nosy_count = 14.0
nosy_names = ['gvanrossum', 'terry.reedy', 'ncoghlan', 'vstinner', 'asvetlov', 'yselivanov', 'miss-islington', 'Dennis Sweeney', 'aeros', 'erlendaasland', 'sobolevn', 'kj', 'kumaraditya', 'arhadthedev']
pr_nums = ['30801', '30811', '30812', '30817', '30845', '30860', '30861']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue41682'
versions = ['Python 3.10', 'Python 3.11']

    Activity

    1. aeros commented on Sep 1, 2020

      @aeros
      aeros
      on Sep 1, 2020
      ContributorAuthor

      In an unrelated PR to add a new argument to the base Executor class for concurrent.futures, there was a test_asyncio failure in test_sendfile for the ProactorEventLoop tests:

      ======================================================================
      FAIL: test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.ProactorEventLoopTests)
      ----------------------------------------------------------------------

      Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_asyncio\test_sendfile.py", line 452, in test_sendfile_close_peer_in_the_middle_of_receiving
    self.run_loop(
AssertionError: ConnectionError not raised

      https://github.com/python/cpython/pull/22023/checks?check_run_id=1049760805#step:5:2373

    2. aeros
      changed the title [-]test_asyncio: Proactor[/-] [+]test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+] on Sep 1, 2020
    3. aeros
      changed the title [-]test_asyncio: Proactor[/-] [+]test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+] on Sep 1, 2020
    4. aeros
      added
      testsTests in the Lib/test dir
      3.10 (EOL)end of life
      type-bugAn unexpected behavior, bug, or error
      on Sep 1, 2020

    5. aeros commented on Sep 1, 2020

      @aeros
      aeros
      on Sep 1, 2020
      ContributorAuthor

      In case the link to the logs are lost from closing and reopening the PR, it was a Windows CI test (GitHub actions) ran with the following configuration:

      D:\a\cpython\cpython>"D:\a\cpython\cpython\PCbuild\amd64\python.exe" -u -Wd -E -bb -m test -uall -u-cpu -rwW --slowest --timeout 1200 -j0
      == CPython 3.10.0a0 (remotes/pull/22023/merge:992cc27, Aug 31 2020, 06:11:21) [MSC v.1927 64 bit (AMD64)]
      == Windows-10-10.0.17763-SP0 little-endian
      == cwd: D:\a\cpython\cpython\build\test_python_6372�
      == CPU count: 2
      == encodings: locale=cp1252, FS=utf-8
      Using random seed 491155
      0:00:00 Run tests in parallel using 4 child processes (timeout: 20 min, worker timeout: 25 min)

    6. aeros
      added
      OS-windows
      topic-asyncio
      on Sep 1, 2020

    7. vstinner commented on Apr 15, 2021

      @vstinner
      vstinner
      on Apr 15, 2021
      Member

      I marked bpo-42124 and bpo-43539 as a duplicate of this issue.

    8. 16 remaining items

    9. asvetlov commented on Jan 24, 2022

      @asvetlov
      asvetlov
      on Jan 24, 2022
      Contributor

      Guido, I can not confirm your suggestion but it seems correct to me.

    10. vstinner commented on Jan 25, 2022

      @vstinner
      vstinner
      on Jan 25, 2022
      Member

      Test fixed on Windows 2022 by:

      commit 1c705fd
      Author: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
      Date: Tue Jan 25 02:34:47 2022 +0530

      fixed flaky test (GH-30845)

    11. vstinner commented on Jan 25, 2022

      @vstinner
      vstinner
      on Jan 25, 2022
      Member

      New changeset 75d88b9 by Miss Islington (bot) in branch '3.10':
      bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (bpo-30860)
      75d88b9

    12. vstinner commented on Jan 25, 2022

      @vstinner
      vstinner
      on Jan 25, 2022
      Member

      New changeset f9ff0bf by Miss Islington (bot) in branch '3.9':
      bpo-41682: fixed flaky test test_sendfile_close_peer_in_the_middle_of_receiving (GH-30845) (bpo-30861)
      f9ff0bf

    13. vstinner commented on Jan 25, 2022

      @vstinner
      vstinner
      on Jan 25, 2022
      Member

      Thanks Kumar for the fix!

    14. vstinner
      closed this as completedon Jan 25, 2022
    15. vstinner
      closed this as completedon Jan 25, 2022

    16. vstinner commented on Jan 25, 2022

      @vstinner
      vstinner
      on Jan 25, 2022
      Member

      This failing test was one of my most hated test because it failed randomly for almost 2 years. I'm happy that it has been fixed :-)

      Regularly, I'm asking for help to fix test_asyncio:

      Last years I gave up, since almost no one replied to my requests.

    17. vstinner
      changed the title [-][Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/-] [+][Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+] on Jan 25, 2022
    18. vstinner
      changed the title [-][Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/-] [+][Windows] : Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure[/+] on Jan 25, 2022

    19. asvetlov commented on Jan 25, 2022

      @asvetlov
      asvetlov
      on Jan 25, 2022
      Contributor

      I'm sorry, Victor.

    20. vstinner commented on Jan 25, 2022

      @vstinner
      vstinner
      on Jan 25, 2022
      Member

      I'm sorry, Victor.

      As a maintainer of the Python CIs, The Night's Watch (*), it's my fault that I didn't skip these tests earlier. Honestly, it's ok to skip a bunch of tests or even remove them if there is no active maintainer.

      It's also ok that there is no active maintainer if existing tests continue to pass. asyncio is far from being an exception. Just look at test_nntplib: not maintained for 9 years, https://bugs.python.org/issue40735

      This test failure got more attention since it started to fail even more frequently (always?) on Windows 2022.

      (*) https://pythondev.readthedocs.io/ci.html#the-night-s-watch-is-fixing-the-cis-in-the-darkness-for-you

    21. ezio-melotti
      transferred this issue fromon Apr 10, 2022

    22. tasty0tomato commented on Oct 3, 2023

      @tasty0tomato
      tasty0tomato
      on Oct 3, 2023

      I built 3.11.5 on my own Windows computer, and found it passed this test on one computer, but didn't pass on another computer. I think that this issue may not be fixed completely, or I can provide needed information of the computer which this test didn't pass to find out the reason why it didn't pass.

    23. vstinner commented on Oct 3, 2023

      @vstinner
      vstinner
      on Oct 3, 2023
      Member

      This issue is closed, please open a new issue.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.10 (EOL)end of life3.11only security fixesOS-windowstestsTests in the Lib/test dirtopic-asynciotype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions