You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The __init__ method for IPv4Network has a typo where it says all three of '192.0.2.0/24', '192.0.2.0/255.255.255.0' and '192.0.0.2/0.0.0.255' should be equal.
The issue resulting in the addition of a "backport-52f9842-3.9" branch to the main python/cpython repository. I believe that this is a mistake and should be removed, but I don't know how.
When miss-islington fails to backport for reasons other than a merge conflict, the problem is likely transient -- perhaps a timing issue or temporary resource unavailable issue that we have no control over. The solution is to delete the backport label, close the label box, reopen the label box, add the label, and reclose. I did this and the auto backport was generated. (The 3.8 backport is ready to approve and merge.)
Thanks, Terry. That was my fault, trying to cherry pick manually. I'm not sure why the original backport failed, and once I did the manual cherry pick as suggested I got called away for real work. As you say, I should have tried deleting the tag and re-adding it before I pulled out the cherry pick tool.
Activity
ericfrederich commentedon Aug 4, 2020
The __init__ method for IPv4Network has a typo where it says all three of '192.0.2.0/24', '192.0.2.0/255.255.255.0' and '192.0.0.2/0.0.0.255' should be equal.
ericvsmith commentedon Aug 5, 2020
New changeset 52f9842 by Eric L. Frederich in branch 'master':
bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
52f9842
terryjreedy commentedon Aug 5, 2020
The issue resulting in the addition of a "backport-52f9842-3.9" branch to the main python/cpython repository. I believe that this is a mistake and should be removed, but I don't know how.
When miss-islington fails to backport for reasons other than a merge conflict, the problem is likely transient -- perhaps a timing issue or temporary resource unavailable issue that we have no control over. The solution is to delete the backport label, close the label box, reopen the label box, add the label, and reclose. I did this and the auto backport was generated. (The 3.8 backport is ready to approve and merge.)
miss-islington commentedon Aug 5, 2020
New changeset b5789a7 by Miss Islington (bot) in branch '3.8':
bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
b5789a7
terryjreedy commentedon Aug 5, 2020
Since this is a trivial typo fix, I approved the backport for auto-merge.
terryjreedy commentedon Aug 5, 2020
I was able to delete the spurious branch because it was not protected.
miss-islington commentedon Aug 5, 2020
New changeset b49b88a by Miss Islington (bot) in branch '3.9':
bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
b49b88a
ericvsmith commentedon Aug 5, 2020
Thanks, Terry. That was my fault, trying to cherry pick manually. I'm not sure why the original backport failed, and once I did the manual cherry pick as suggested I got called away for real work. As you say, I should have tried deleting the tag and re-adding it before I pulled out the cherry pick tool.
Thank you for cleaning up after me.