Skip to content

docstring errors in ipaddress.IPv4Network #85654

Closed

Description

@ericfrederich
BPO 41482
Nosy @terryjreedy, @ericvsmith, @ericfrederich, @miss-islington
PRs
  • bpo-41482: Fix error in ipaddress.IPv4Network docstring #21736
  • [3.8] bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736) #21746
  • [3.9] bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736) #21747
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = None
    created_at = <Date 2020-08-04.19:54:05.292>
    labels = ['type-bug', '3.8', '3.9', '3.10', 'docs']
    title = 'docstring errors in ipaddress.IPv4Network'
    updated_at = <Date 2020-08-05.22:03:53.292>
    user = 'https://github.com/ericfrederich'

    bugs.python.org fields:

    activity = <Date 2020-08-05.22:03:53.292>
    actor = 'eric.smith'
    assignee = 'docs@python'
    closed = False
    closed_date = None
    closer = None
    components = ['Documentation']
    creation = <Date 2020-08-04.19:54:05.292>
    creator = 'eric.frederich'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 41482
    keywords = ['patch']
    message_count = 8.0
    messages = ['374841', '374894', '374902', '374903', '374904', '374905', '374906', '374907']
    nosy_count = 6.0
    nosy_names = ['terry.reedy', 'eric.smith', 'docs@python', 'python-dev', 'eric.frederich', 'miss-islington']
    pr_nums = ['21736', '21746', '21747']
    priority = 'normal'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue41482'
    versions = ['Python 3.8', 'Python 3.9', 'Python 3.10']

    Activity

    1. ericfrederich commented on Aug 4, 2020

      ericfrederichmannequin
      MannequinAuthor

      The __init__ method for IPv4Network has a typo where it says all three of '192.0.2.0/24', '192.0.2.0/255.255.255.0' and '192.0.0.2/0.0.0.255' should be equal.

    2. ericvsmith commented on Aug 5, 2020

      @ericvsmith
      Member

      New changeset 52f9842 by Eric L. Frederich in branch 'master':
      bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
      52f9842

    3. terryjreedy commented on Aug 5, 2020

      @terryjreedy
      Member

      The issue resulting in the addition of a "backport-52f9842-3.9" branch to the main python/cpython repository. I believe that this is a mistake and should be removed, but I don't know how.

      When miss-islington fails to backport for reasons other than a merge conflict, the problem is likely transient -- perhaps a timing issue or temporary resource unavailable issue that we have no control over. The solution is to delete the backport label, close the label box, reopen the label box, add the label, and reclose. I did this and the auto backport was generated. (The 3.8 backport is ready to approve and merge.)

    4. added
      type-bugAn unexpected behavior, bug, or error
      and removed
      type-featureA feature request or enhancement
      on Aug 5, 2020
    5. miss-islington commented on Aug 5, 2020

      @miss-islington
      Contributor

      New changeset b5789a7 by Miss Islington (bot) in branch '3.8':
      bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
      b5789a7

    6. terryjreedy commented on Aug 5, 2020

      @terryjreedy
      Member

      Since this is a trivial typo fix, I approved the backport for auto-merge.

    7. terryjreedy commented on Aug 5, 2020

      @terryjreedy
      Member

      I was able to delete the spurious branch because it was not protected.

    8. miss-islington commented on Aug 5, 2020

      @miss-islington
      Contributor

      New changeset b49b88a by Miss Islington (bot) in branch '3.9':
      bpo-41482: Fix error in ipaddress.IPv4Network docstring (GH-21736)
      b49b88a

    9. ericvsmith commented on Aug 5, 2020

      @ericvsmith
      Member

      Thanks, Terry. That was my fault, trying to cherry pick manually. I'm not sure why the original backport failed, and once I did the manual cherry pick as suggested I got called away for real work. As you say, I should have tried deleting the tag and re-adding it before I pulled out the cherry pick tool.

      Thank you for cleaning up after me.

    10. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.10 (EOL)end of life3.8 (EOL)end of life3.9 (EOL)end of lifedocsDocumentation in the Doc dirtype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions