Skip to content

Add Windows ARM32 buildbot #80692

Closed
Closed
Add Windows ARM32 buildbot#80692
Labels
3.8 (EOL)end of life3.9 (EOL)end of lifeOS-windowsbuildThe build process and cross-buildtype-featureA feature request or enhancement

Description

@paulmon
paulmon
mannequin
opened on Apr 2, 2019
BPO 36511
Nosy @pfmoore, @db3l, @vstinner, @tjguk, @ned-deily, @zware, @zooba, @miss-islington, @paulmon
PRs
  • bpo-36511: Windows arm32 buildbot changes #12917
  • bpo-36511: Windows arm32 buildbot changes (remove extra space) #13351
  • bpo-36511: Fix Windows arm32 buildbot pythoninfo, scp, and ssh #13454
  • bpo-36511: propagate error code #13529
  • [3.8] bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (GH-13454) #14244
  • bpo-36511 add arm32 buildbot diagnostic messages #14251
  • [3.8] bpo-36511: Improve ARM32 buildbot scripts (GH-14251) #14279
  • bpo-36511: fix -u parameters #14280
  • [3.8] bpo-36511: Fix -u parameters for ARM32 tests (GH-14280) #14290
  • bpo-36511: clean up python process before deploy #14431
  • bpo-37552 strptime/strftime return invalid results with UCRT version 17763.615 #14460
  • bpo-36511 fix failures in Windows Python arm32 buildbot tests #15181
  • [3.8] bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181) #15186
  • [3.8] bpo-37531: Fix regrtest timeout for subprocesses (GH-15072) #15279
  • [3.8] bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181) #15571
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2019-04-02.19:09:21.569>
labels = ['type-feature', '3.8', 'OS-windows', 'build', '3.9']
title = 'Add Windows ARM32 buildbot'
updated_at = <Date 2019-09-10.07:33:33.875>
user = 'https://github.com/paulmon'

    bugs.python.org fields:

    activity = <Date 2019-09-10.07:33:33.875>
actor = 'vstinner'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Build', 'Windows']
creation = <Date 2019-04-02.19:09:21.569>
creator = 'Paul Monson'
dependencies = []
files = []
hgrepos = []
issue_num = 36511
keywords = ['patch']
message_count = 21.0
messages = ['339362', '342611', '342612', '342614', '342661', '343320', '343321', '343322', '343406', '346081', '346133', '346165', '346233', '346256', '349267', '349705', '350715', '350716', '350717', '351551', '351586']
nosy_count = 9.0
nosy_names = ['paul.moore', 'db3l', 'vstinner', 'tim.golden', 'ned.deily', 'zach.ware', 'steve.dower', 'miss-islington', 'Paul Monson']
pr_nums = ['12917', '13351', '13454', '13529', '14244', '14251', '14279', '14280', '14290', '14431', '14460', '15181', '15186', '15279', '15571']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue36511'
versions = ['Python 3.8', 'Python 3.9']

    Activity

    1. paulmon commented on Apr 2, 2019

      @paulmon
      paulmonmannequin
      on Apr 2, 2019
      MannequinAuthor

      Zachary Ware suggested I create an issue to discuss this:

      I've started a worker using the worker name monson-win-arm32 and the password provided.

      I think it is waiting for a change, there were no errors, but it didn't print anything.

      Also, I don’t see anything in the list of builders that looks like it would be windows arm32, and it's not showing in the list of workers.

      I'm looking at tools/buildbot/test.bat and it seems like it might be a good place to use SSH to run the test on arm32 device, but I'm not clear on where it is called from or what the best way to detect that project is being cross-compiled.

      Should I add an "-arm32" switch here?

    2. paulmon
      added
      3.8 (EOL)end of life
      buildThe build process and cross-build
      OS-windows
      type-featureA feature request or enhancement
      on Apr 2, 2019

    3. zooba commented on May 15, 2019

      @zooba
      zooba
      on May 15, 2019
      Member

      New changeset 67ff6a1 by Steve Dower (Paul Monson) in branch 'master':
      bpo-36511: Windows ARM32 buildbot changes (GH-12917)
      67ff6a1

    4. zooba commented on May 15, 2019

      @zooba
      zooba
      on May 15, 2019
      Member

      Going to leave this in commit review for a bit, in case hitting merge suddenly flushes out some reviews :)

    5. miss-islington commented on May 15, 2019

      @miss-islington
      miss-islington
      on May 15, 2019
      Contributor

      New changeset 4f82072 by Miss Islington (bot) (Paul Monson) in branch 'master':
      bpo-36511: Windows arm32 buildbot changes (remove extra space) (GH-13351)
      4f82072

    6. zooba commented on May 16, 2019

      @zooba
      zooba
      on May 16, 2019
      Member

      Paul - looks like there's a timeout being hit due to lack of output. Any ideas?

      https://buildbot.python.org/all/#/builders/203/builds/6

    7. db3l commented on May 23, 2019

      @db3l
      db3l
      on May 23, 2019
      Contributor

      I've been investigating issues with test failures on my Windows buildbots seemingly not showing up in the master's web interface (but just showing warnings), and it appears likely due to this change.

      For example, test_urllib (a test problem from bpo-36948) was failing but only appeared as a warning (the first such case on my Win10 builder for example is https://buildbot.python.org/all/#/builders/3/builds/2661).

      This change appears to force the exit code of test.bat to be successful (0) regardless of the results of the test run, thus obscuring any test failures from a parent process such as the buildbot. As an aside, it also looks like any failures along the new arm32ssh branch would be obscured, assuming that the ssh operation would otherwise have propagated the remote exit code.

      I think just leaving off the exit code (so just "exit /b") should propagate the rt.bat result properly. Or, a goto to a label at the end of the file and letting it exit naturally would mimic the prior behavior.

    8. paulmon commented on May 23, 2019

      @paulmon
      paulmonmannequin
      on May 23, 2019
      MannequinAuthor

      I did a quick test and it looks like exit /b %ERRORLEVEL% will propagate the exit code.

    9. db3l commented on May 23, 2019

      @db3l
      db3l
      on May 23, 2019
      Contributor

      Yeah, I think you're right.

      It looks like without an explicit code, it won't propagate the result as the exit code of cmd itself for those cases where cmd does exit (which would include the buildbots).

    10. zooba commented on May 24, 2019

      @zooba
      zooba
      on May 24, 2019
      Member

      New changeset 51394b8 by Steve Dower (Paul Monson) in branch 'master':
      bpo-36511: Ensure error code propagates out of batch files (GH-13529)
      51394b8

    11. zooba commented on Jun 19, 2019

      @zooba
      zooba
      on Jun 19, 2019
      Member

      New changeset f355069 by Steve Dower (Paul Monson) in branch 'master':
      bpo-36511: Add buildbot scripts and fix tests for Windows ARM32 buildbot (GH-13454)
      f355069

    12. zooba commented on Jun 20, 2019

      @zooba
      zooba
      on Jun 20, 2019
      Member

      New changeset a195212 by Steve Dower (Paul Monson) in branch 'master':
      bpo-36511: Improve ARM32 buildbot scripts (GH-14251)
      a195212

    13. 2 remaining items

    14. zooba commented on Jun 21, 2019

      @zooba
      zooba
      on Jun 21, 2019
      Member

      New changeset f3e38ec by Steve Dower in branch '3.8':
      bpo-36511: Fix -u parameters for ARM32 tests (GH-14280)
      f3e38ec

    15. zooba commented on Aug 8, 2019

      @zooba
      zooba
      on Aug 8, 2019
      Member

      New changeset ed70a34 by Steve Dower (Paul Monson) in branch 'master':
      bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181)
      ed70a34

    16. vstinner commented on Aug 14, 2019

      @vstinner
      vstinner
      on Aug 14, 2019
      Member

      New changeset d85c567 by Victor Stinner in branch '3.8':
      [3.8] bpo-37531: Fix regrtest timeout for subprocesses (GH-15072) (GH-15279)
      d85c567

    17. miss-islington commented on Aug 29, 2019

      @miss-islington
      miss-islington
      on Aug 29, 2019
      Contributor

      New changeset ed00fee by Miss Islington (bot) in branch '3.8':
      bpo-36511: Fix failures in Windows ARM32 buildbot (GH-15181)
      ed00fee

    18. ned-deily commented on Aug 29, 2019

      @ned-deily
      ned-deily
      on Aug 29, 2019
      Member

      I manually restarted and merged the stalled 3.8 backport for 3.8.0b4. Can this issue now be closed?

    19. ned-deily
      added
      3.9 (EOL)end of life
      on Aug 29, 2019

    20. ned-deily commented on Aug 29, 2019

      @ned-deily
      ned-deily
      on Aug 29, 2019
      Member

      Can this issue now be closed?

      I spoke too soon. It appears there's another open backport PR-14244 for this issue that needs some conflict resolution to be merged.

    21. zware commented on Sep 9, 2019

      @zware
      zware
      on Sep 9, 2019
      Member

      New changeset 55d12ce by Zachary Ware (Paul Monson) in branch 'master':
      bpo-36511: clean up python process before deploy on ARM Windows buildbots (GH-14431)
      55d12ce

    22. vstinner commented on Sep 10, 2019

      @vstinner
      vstinner
      on Sep 10, 2019
      Member

      I rejected PR 14244 because there are now many conflicts: the commit f355069 should be backported manually to Python 3.8.

    23. ezio-melotti
      transferred this issue fromon Apr 10, 2022

    24. erlend-aasland commented on May 20, 2022

      @erlend-aasland
      erlend-aasland
      on May 20, 2022
      Contributor

      Can this be closed?

    25. erlend-aasland
      added
      pendingThe issue will be closed if no feedback is provided
      on May 20, 2022

    26. zware commented on May 20, 2022

      @zware
      zware
      on May 20, 2022
      Member

      Yes, I think so.

    27. zware
      closed this as completedon May 20, 2022
    28. zware
      removed
      pendingThe issue will be closed if no feedback is provided
      on May 20, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.8 (EOL)end of life3.9 (EOL)end of lifeOS-windowsbuildThe build process and cross-buildtype-featureA feature request or enhancement

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions