Repository navigation
IDLE: Entry tests should delete before insert. #75595
Description
| BPO | 31414 |
|---|---|
| Nosy | @terryjreedy |
| PRs |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = <Date 2020-01-27.23:37:54.755>
created_at = <Date 2017-09-11.03:17:33.087>
labels = ['expert-IDLE', 'type-bug', '3.7']
title = 'IDLE: Entry tests should delete before insert.'
updated_at = <Date 2020-01-27.23:37:54.754>
user = 'https://github.com/terryjreedy'bugs.python.org fields:
activity = <Date 2020-01-27.23:37:54.754>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = True
closed_date = <Date 2020-01-27.23:37:54.755>
closer = 'terry.reedy'
components = ['IDLE']
creation = <Date 2017-09-11.03:17:33.087>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 31414
keywords = ['patch']
message_count = 4.0
messages = ['301851', '301896', '301898', '360822']
nosy_count = 1.0
nosy_names = ['terry.reedy']
pr_nums = ['3501', '3502']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue31414'
versions = ['Python 3.6', 'Python 3.7']Linked PRs
- gh-83653: Do not save a blank int entry in IDLE Settings #152743
- [3.15] gh-83653: Do not save a blank int entry in IDLE Settings (GH-152743) #152827
- [3.14] gh-83653: Do not save a blank int entry in IDLE Settings (GH-152743) #152828
- [3.13] gh-83653: Do not save a blank int entry in IDLE Settings (GH-152743) #152829
Activity
terryjreedy commentedon Sep 11, 2017
Test_configdialog 'tests' several integer entry widgets by inserting a digit and then checking that the new value was sent to changes. However, users may delete an entry totally and enter a new value. If we associate an IntVar with the entry widget, int('') is called somewhere in the process, which raises. (IntVar(root).set('') does not, so the error is somewhere further along. The test should imitate users by delete and insert.
Note: a deeper problem is attaching a tracer that get called with each keystroke. Using a StringVar avoids the error when the entry is blanked, but currently allows non-ints to be saved. A better solution would be to not do the auto tracing, but use a IntVar and only call var_changed when the user 'leaves' the box, after checking for a count in a sane range.
terryjreedy commentedon Sep 11, 2017
New changeset 667522e by Terry Jan Reedy in branch 'master':
bpo-31414: IDLE -- fix tk entry box tests by deleting first. (bpo-3501)
667522e
terryjreedy commentedon Sep 11, 2017
New changeset 31b2424 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.6':
[3.6] bpo-31414: IDLE -- fix tk entry box tests by deleting first. (GH-3501) (bpo-3502)
31b2424
terryjreedy commentedon Jan 27, 2020
Opened bpo-39472 for changes dialog itself.
gh-75595: Do not save a blank int entry in IDLE Settings (#152743)
[3.13] gh-75595: Do not save a blank int entry in IDLE Settings (GH-1…
[3.14] gh-75595: Do not save a blank int entry in IDLE Settings (GH-1…
[3.15] gh-75595: Do not save a blank int entry in IDLE Settings (GH-1…