Repository navigation
Missing terminator option when using readline with socketserver.StreamRequestHandler #75547
Description
| BPO | 31366 |
|---|---|
| Nosy | @vadmium, @tfeldmann |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2017-09-06.14:37:14.332>
labels = ['type-feature', 'library']
title = 'Missing terminator option when using readline with socketserver.StreamRequestHandler'
updated_at = <Date 2017-09-08.22:52:04.530>
user = 'https://github.com/tfeldmann'bugs.python.org fields:
activity = <Date 2017-09-08.22:52:04.530>
actor = 'martin.panter'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2017-09-06.14:37:14.332>
creator = 'tfeldmann'
dependencies = []
files = []
hgrepos = []
issue_num = 31366
keywords = []
message_count = 2.0
messages = ['301474', '301753']
nosy_count = 2.0
nosy_names = ['martin.panter', 'tfeldmann']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue31366'
versions = []
Activity
tfeldmann commentedon Sep 6, 2017
When using
socketserver.StreamRequestHandlerit should be possible to specify the newline terminator that is passed toself.connection.makefile().This would be greatly appreciated by many people who have to work with network packets ending with
\0.vadmium commentedon Sep 8, 2017
The socket.makefile(newline=...) parameter only affects text mode, but StreamRequestHandler’s “rfile” attribute works in byte mode. You could call makefile or TextIOWrapper yourself, but neither of these options support reading null-terminated “lines” or packets.
I think it would be best to implement this more generally, e.g. via bpo-1152248 or bpo-17083. Perhaps like the “asyncio.StreamReader.readuntil” or “telnetlib.Telnet.read_until” methods, rather than a stream configuration option.