Skip to content

zipfile.ZipFile fails reading a file object in specific version(s) #70460

Closed
Closed
zipfile.ZipFile fails reading a file object in specific version(s)#70460
Labels
stdlibStandard Library Python modules in the Lib/ directorytype-crashA hard crash of the interpreter, possibly with a core dump

Description

@starrify
starrify
mannequin
opened on Feb 3, 2016
BPO 26272
Nosy @vadmium, @starrify

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2016-02-03.09:03:00.554>
created_at = <Date 2016-02-03.08:48:27.454>
labels = ['library', 'type-crash']
title = '`zipfile.ZipFile` fails reading a file object in specific version(s)'
updated_at = <Date 2016-02-03.09:04:02.366>
user = 'https://github.com/starrify'

bugs.python.org fields:

activity = <Date 2016-02-03.09:04:02.366>
actor = '__starrify__'
assignee = 'none'
closed = True
closed_date = <Date 2016-02-03.09:03:00.554>
closer = '__starrify__'
components = ['Library (Lib)']
creation = <Date 2016-02-03.08:48:27.454>
creator = '__starrify__'
dependencies = []
files = []
hgrepos = []
issue_num = 26272
keywords = []
message_count = 4.0
messages = ['259459', '259461', '259462', '259463']
nosy_count = 2.0
nosy_names = ['martin.panter', '__starrify__']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = 'crash'
url = 'https://bugs.python.org/issue26272'
versions = ['Python 3.5']

Activity

  1. starrify commented on Feb 3, 2016

    @starrify
    starrifymannequin
    on Feb 3, 2016
    MannequinAuthor

    When passing a file object to zipfile.ZipFile for reading it fails in Python 3.5.1 it fails. While the same code in Python 2.7.11 works.
    Also loading that specific file directly from file path works in Python 3.5.1.
    (Please see the sample testing code below for details)

    [pengyu@GLaDOS tmp]$ echo "test message" > testfile
[pengyu@GLaDOS tmp]$ zip testfile.zip testfile
updating: testfile (stored 0%)
[pengyu@GLaDOS tmp]$ file testfile.zip 
testfile.zip: Zip archive data, at least v1.0 to extract
[pengyu@GLaDOS tmp]$ python -c "a = open('testfile.zip'); import zipfile; b = zipfile.ZipFile(a, 'r')"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.5/zipfile.py", line 1026, in __init__
    self._RealGetContents()
  File "/usr/lib/python3.5/zipfile.py", line 1093, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file
[pengyu@GLaDOS tmp]$ python2 -c "a = open('testfile.zip'); import zipfile; b = zipfile.ZipFile(a, 'r')"
[pengyu@GLaDOS tmp]$ python -c "import zipfile; b = zipfile.ZipFile('testfile.zip', 'r')"
[pengyu@GLaDOS tmp]$ python --version
Python 3.5.1
[pengyu@GLaDOS tmp]$ python2 --version
Python 2.7.11
  2. starrify
    added
    stdlibStandard Library Python modules in the Lib/ directory
    type-crashA hard crash of the interpreter, possibly with a core dump
    on Feb 3, 2016

  3. vadmium commented on Feb 3, 2016

    @vadmium
    vadmium
    on Feb 3, 2016
    Member

    I think you are only meant to pass in a “binary” (bytes) file object. Maybe BufferedIOBase, I’m not sure. The documentation doesn’t seem to make this very clear though. Can you suggest an improvement?

    Open the file with

    a = open("testfile.zip", "rb")

    and all should be well :)

  4. starrify commented on Feb 3, 2016

    @starrify
    starrifymannequin
    on Feb 3, 2016
    MannequinAuthor

    Well I should have noticed that I wasn't using binary mode.. Sorry for the mistake. Closing the issue report.

  5. starrify
    closed this as completedon Feb 3, 2016

  6. starrify commented on Feb 3, 2016

    @starrify
    starrifymannequin
    on Feb 3, 2016
    MannequinAuthor

    Oh yes you're right Martin. Thanks for the notice :) (I've closed this ticket before seeing your reply)

  7. ezio-melotti
    transferred this issue fromon Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytype-crashA hard crash of the interpreter, possibly with a core dump

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions