bring BTPROTO_SCO inline with other Bluetooth protocols #69232

Activity

1. TimTisdall commented on Sep 9, 2015

   

   TimTisdallmannequin

   on Sep 9, 2015

   MannequinAuthor

   More actions

   All of the BTPROTO_ protocols accept tuples with Bluetooth addresses as regular strings. SCO accepts a byte-string which represents a Bluetooth address. The change was made at 23ab586c427a

   With the current implementation we get this error:

   >>> import socket
   >>> x = socket.socket(socket.AF_BLUETOOTH, socket.SOCK_SEQPACKET, socket.BTPROTO_SCO)
   >>> x.bind(socket.BDADDR_ANY)
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   OSError: getsockaddrarg: wrong format

   This is because socket.BDADDR_ANY is a string while the bind() is expecting a binary string. So the workaround would be to call x.bind(socket.BDADDR_ANY.encode()) .

   Is it acceptable to change it to accept a regular string to match the other address methods and constants? This would be essentially a breaking change, however on something that wasn't really documented prior to bpo-24984 .

   I'll submit a patch when the repo is back up...
2. TimTisdall

   added

   type-featureA feature request or enhancementA feature request or enhancement

   extension-modulesC modules in the Modules dirC modules in the Modules dir

   on Sep 9, 2015
3. vadmium commented on Sep 9, 2015

   

   vadmium

   on Sep 9, 2015

   Member

   More actions

   Perhaps making it accept both bytes and text strings is a sensible option. Similar to how AF_INET can bind to both "localhost" and b"localhost".
4. TimTisdall commented on Sep 10, 2015

   

   TimTisdallmannequin

   on Sep 10, 2015

   MannequinAuthor

   More actions

   Yes, then any existing implementations will continue to work.

   One sticky issue with all of this... there's no existing tests as per bpo-7687 .
5. devdanzin

   added

   3.11only security fixesonly security fixes

   on Dec 27, 2021
6. ezio-melotti

   transferred this issue fromon Apr 10, 2022
7. serhiy-storchaka

   added

   topic-socketRelated to the socket, socketserver and selectors modulesRelated to the socket, socketserver and selectors modules

   on Jul 3, 2026