Skip to content

pathlib.PureWindowsPath doesn't join relative paths correctly when a drive is present #64107

Closed

Description

@serhiy-storchaka
BPO 19908
Nosy @pitrou, @serhiy-storchaka
Files
  • joinwinpath.patch
  • joinwinpath_2.patch
  • joinwinpath_3.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2013-12-06.15:20:54.320>
    created_at = <Date 2013-12-06.11:50:09.609>
    labels = ['type-bug', 'library']
    title = "pathlib.PureWindowsPath doesn't join relative paths correctly when a drive is present"
    updated_at = <Date 2013-12-06.15:26:17.761>
    user = 'https://github.com/serhiy-storchaka'

    bugs.python.org fields:

    activity = <Date 2013-12-06.15:26:17.761>
    actor = 'python-dev'
    assignee = 'none'
    closed = True
    closed_date = <Date 2013-12-06.15:20:54.320>
    closer = 'serhiy.storchaka'
    components = ['Library (Lib)']
    creation = <Date 2013-12-06.11:50:09.609>
    creator = 'serhiy.storchaka'
    dependencies = []
    files = ['33003', '33006', '33007']
    hgrepos = []
    issue_num = 19908
    keywords = ['patch']
    message_count = 9.0
    messages = ['205364', '205365', '205369', '205374', '205375', '205376', '205377', '205378', '205379']
    nosy_count = 3.0
    nosy_names = ['pitrou', 'python-dev', 'serhiy.storchaka']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue19908'
    versions = ['Python 3.4']

    Activity

    1. serhiy-storchaka commented on Dec 6, 2013

      @serhiy-storchaka
      MemberAuthor
      >>> pathlib.PureWindowsPath('C:/a/b').joinpath('D:x/y')
      PureWindowsPath('D:/a/b/D:/x/y')

      See also bpo-19456.

    2. added
      stdlibStandard Library Python modules in the Lib/ directory
      type-bugAn unexpected behavior, bug, or error
      on Dec 6, 2013
    3. pitrou commented on Dec 6, 2013

      @pitrou
      Member

      Here is a patch.

    4. serhiy-storchaka commented on Dec 6, 2013

      @serhiy-storchaka
      MemberAuthor

      Here is simplified patch.

    5. pitrou commented on Dec 6, 2013

      @pitrou
      Member

      Thanks! Patch looks ok to me.

    6. serhiy-storchaka commented on Dec 6, 2013

      @serhiy-storchaka
      MemberAuthor

      Ah, drives should be compared with ignored cases.

    7. pitrou commented on Dec 6, 2013

      @pitrou
      Member

      Good point :)

    8. python-dev commented on Dec 6, 2013

      python-devmannequin
      Mannequin

      New changeset 1ba15c3f45fa by Serhiy Storchaka in branch 'default':
      Issue bpo-19908: pathlib now joins relative Windows paths correctly when a drive
      http://hg.python.org/cpython/rev/1ba15c3f45fa

    9. serhiy-storchaka commented on Dec 6, 2013

      @serhiy-storchaka
      MemberAuthor

      Thank you Antoine for your patch.

    10. python-dev commented on Dec 6, 2013

      python-devmannequin
      Mannequin

      New changeset 0c508d87f80b by Serhiy Storchaka in branch 'default':
      Test same drive in different cases (issue bpo-19908).
      http://hg.python.org/cpython/rev/0c508d87f80b

    11. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions