Repository navigation
Pdb does not stop at a breakpoint set on the line of a function definition #59013
Description
| BPO | 14808 |
|---|---|
| Nosy | @birkenfeld, @xdegaye |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2012-05-14.15:36:58.639>
labels = ['type-bug', 'library']
title = 'Pdb does not stop at a breakpoint set on the line of a function definition'
updated_at = <Date 2012-05-25.11:56:43.789>
user = 'https://github.com/xdegaye'bugs.python.org fields:
activity = <Date 2012-05-25.11:56:43.789>
actor = 'xdegaye'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2012-05-14.15:36:58.639>
creator = 'xdegaye'
dependencies = []
files = ['25578']
hgrepos = []
issue_num = 14808
keywords = ['patch']
message_count = 2.0
messages = ['160629', '161574']
nosy_count = 2.0
nosy_names = ['georg.brandl', 'xdegaye']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue14808'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']
Activity
xdegaye commentedon May 14, 2012
In the following test both breakpoints are set on the line of a
function definition. However pdb does not stop when entering foo whose
breakpoint has been set with 'break 1' while pdb stops when entering
bar whose breakpoint has been set with 'break bar'. The breakpoint
table display is identical for both breakpoints. This is inconsistent
and confusing.
=== main.py ==================================
1 def foo():
2 pass
3
4 def bar():
5 pass
6
7 def main():
8 foo()
9 bar()
10
11 import pdb; pdb.runcall(main)
=================================================
=================================================
The reverse occurs in the following test where pdb stops only at the
execution of the function definition when the breakpoint has been set
with a line number.
=== main.py ==================================
1 x = 1
2
3 def foo():
4 pass
5
6 def bar():
7 pass
8
9 x = 2
=================================================
=================================================
The following patch fixes both inconsistencies by having pdb stop when
entering a function and at the execution of a definition whatever the
method used to set the breakpoint (line number or function name).
Two test cases are included in the patch.
xdegaye commentedon May 25, 2012
Parsing the modules source seems a better way to fix this problem, see bpo-14913.
gh-59013: Make line number of function breakpoint more precise (#110582)
gaogaotiantian commentedon Oct 27, 2023
With #110852,
break funcwill assign the correct line number for function that is already defined.pythongh-59013: Make line number of function breakpoint more precise (p…
hugovk commentedon Nov 27, 2023
Fixed by #110582, thanks!
gaogaotiantian commentedon Nov 27, 2023
Actually, there's still a case that's inconsistent. I did not figure out a solution then but I have a patch now. Let's reopen this and close it after the new PR is merged.
gh-59013: Set breakpoint on the first executable line of function whe…
gaogaotiantian commentedon Feb 2, 2024
With #112470 merged, this problem is fully fixed.
pythongh-59013: Make line number of function breakpoint more precise (p…
pythongh-59013: Set breakpoint on the first executable line of functi…
pythongh-59013: Make line number of function breakpoint more precise (p…