intern_static() never detects a failed _Py_hashtable_set() (< -1 should be < 0)

Bug report

Bug description:

In intern_static() in Objects/unicodeobject.c, the result of _Py_hashtable_set() is compared with < -1:

Line 14591 in 21223c9

if (_Py_hashtable_set(INTERNED_STRINGS, s, s) < -1) {

)

_Py_hashtable_set() (Python/hashtable.c) returns 0 on success and -1 when the entry allocation fails, so this condition is never true and the Py_FatalError() call is unreachable.

The check has been like this since gh-120520, so 3.13, 3.14 and main are affected.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

hey, can i work on this one?

@Vara715

@Vara715 Why? What's wrong with the already existing PR? What would you do differently?

gh-157892: Fix error check on _Py_hashtable_set() in intern_static() (#…

[3.13] gh-157892: Fix error check on _Py_hashtable_set() in intern_st…

[3.14] gh-157892: Fix error check on _Py_hashtable_set() in intern_st…

[3.15] gh-157892: Fix error check on _Py_hashtable_set() in intern_st…

Navigation Menu

Repository navigation

`intern_static()` never detects a failed `_Py_hashtable_set()` (`< -1` should be `< 0`) #157892

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

intern_static() never detects a failed _Py_hashtable_set() (< -1 should be < 0) #157892

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

Vara715 commented on Sep 27, 2026

pochmann commented on Sep 27, 2026

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`intern_static()` never detects a failed `_Py_hashtable_set()` (`< -1` should be `< 0`) #157892