Skip to content

initconfig.c: SET_ITEM macro leaks dict on expression failure #146244

Closed
Closed
initconfig.c: SET_ITEM macro leaks dict on expression failure#146244
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

Description

@Wulian233
Wulian233
opened on Mar 21, 2026

Bug report

Bug description:

Parent: #146102

SET_ITEM macro at line 510-521: when the expression (e.g., PyLong_FromLong) returns NULL, return NULL at line 514 leaks the dict allocated at line 505. The PyDict_SetItemString failure path correctly uses goto fail.

CPython versions tested on:

CPython main branch

Linked PRs

Activity

  1. Wulian233
    added
    type-bugAn unexpected behavior, bug, or error
    on Mar 21, 2026
  2. aisk
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Mar 21, 2026

  3. Wulian233 commented on Mar 21, 2026

    @Wulian233
    Wulian233
    on Mar 21, 2026
    ContributorAuthor

    I’m currently unable to add the parent issue #146102 . I would appreciate it if someone could help add it:)

  4. aisk
    added a parent issue on Mar 21, 2026
  5. serhiy-storchaka
    added a commit that references this issue on Mar 25, 2026

    gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expression f…

    9343518
  6. miss-islington
    added 2 commits that reference this issue on Mar 25, 2026

    pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres…

    760194e

    pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres…

    e71c242
  7. serhiy-storchaka
    closed this as completedon Mar 25, 2026
  8. serhiy-storchaka
    added 2 commits that reference this issue on Mar 25, 2026

    [3.13] gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expre…

    fc4b422

    [3.14] gh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expre…

    4d61fd6
  9. clin1234
    added a commit that references this issue on Apr 16, 2026

    pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres…

    41d4bf9
  10. ljfp
    added a commit that references this issue on Apr 25, 2026

    pythongh-146244: Fix initconfig.c SET_ITEM macro leaks dict on expres…

    f383929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions