Skip to content

code_richcompare swallows errors #146199

Description

@brijkapadia

Bug report

Bug description:

This is a sub-issue for #146102 and more details can be found here.


In code_richcompare on line 2608, PyObject_RichCompareBool can return an error (-1), but that is treated incorrectly since !(-1) == 0 . Reproducer:

class BadStr(str):
    _armed = False
    def __eq__(self, other):
        if BadStr._armed and isinstance(other, str) and str.__eq__(self, other):
            raise RuntimeError("Poison!")
        return str.__eq__(self, other)
    def __hash__(self): return str.__hash__(self)

c1 = compile("pass", "test", "exec")
c2 = c1.replace(co_name=BadStr("poison"))
c3 = compile("pass", "poison", "exec")
BadStr._armed = True
c2 == c3  # assertion: !_PyErr_Occurred(tstate)

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. added a commit that references this issue on Mar 20, 2026
  2. added a commit that references this issue on Mar 23, 2026
  3. added a commit that references this issue on Mar 24, 2026
  4. added a commit that references this issue on Apr 16, 2026
  5. added a commit that references this issue on Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions