Repository navigation
Tachyon's StackTraceCollector has two different ways to set skip_idle #145458
Description
I was looking at the code in Tachyon and I think I've found something that isn't quite right (or at least is misleading and needs to be documented?)
In the StackTraceCollector, it seems like self.skip_idle is set but never used, as every collect method gets another skip_idle parameter that they use in _iter_stacks (or their calls to parent class' methods).
Based on the code for e.g. live_collector, it seems like the pattern is to use the attribute, not a parameter.
Activity
pythongh-145458: use self.skip_idle
picnixz commentedon Mar 3, 2026
When you are not sure about something, please avoid create draft PRs and wait for a maintainer to acknowledge the issue. You can say that you have a PR ready in case this is acknowledge but please avoid opening PRs that are not sure to be merged.
KowalskiThomas commentedon Mar 3, 2026
Sounds good, noted. Sorry about this. I'll avoid doing this in the future.
encukou commentedon Mar 10, 2026
cc @pablogsal
gh-145458: use `self.skip_idle` consistently in the tachyon profiler (#…
Merge branch 'main' into tachyon-ndjson-kolektor
KowalskiThomas commentedon Apr 8, 2026
I think we can close this, right? Now that #145459 is merged.
pythongh-145458: use `self.skip_idle` consistently in the tachyon pro…
pythongh-145458: use `self.skip_idle` consistently in the tachyon pro…