Skip to content

Remove unused local variable in PyImport_ImportModuleLevelObject #142666

Closed
Closed
Remove unused local variable in PyImport_ImportModuleLevelObject#142666
Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)

Description

@hyongtao-code
hyongtao-code
opened on Dec 13, 2025

Bug report

Bug description:

While learning PyImport_ImportModuleLevelObject, I noticed that the local
variable package is initialized to NULL, never assigned or used, and only
passed to Py_XDECREF at function exit.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Windows

Linked PRs

Activity

  1. hyongtao-code
    added
    type-bugAn unexpected behavior, bug, or error
    on Dec 13, 2025

  2. hyongtao-code commented on Dec 13, 2025

    @hyongtao-code
    hyongtao-code
    on Dec 13, 2025
    ContributorAuthor

    Sorry, I shouldn’t have selected the type-bug label when creating the issue; I should have used the blank template instead. Please help me remove this incorrect label.

  3. sergey-miryanov
    added
    type-refactorCode refactoring (with no changes in behavior)
    and removed
    type-bugAn unexpected behavior, bug, or error
    on Dec 13, 2025
  4. StanFromIreland
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    on Dec 13, 2025
  5. serhiy-storchaka
    added a commit that references this issue on Dec 14, 2025

    gh-142666: Remove unused variable package in import logic (GH-142667)

    e90e6d1
  6. serhiy-storchaka
    closed this as completedon Dec 14, 2025
  7. fatelei
    added a commit that references this issue on Dec 16, 2025

    pythongh-142666: Remove unused variable package in import logic (pyth…

    ff48e57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-refactorCode refactoring (with no changes in behavior)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions