Skip to content

Incorrect hard limit for stack protection for MacOS and TSAN #139291

Description

@markshannon

Bug description:

Largely as a result of mixing the logic for determining the hardware stack limits and for setting the software stack limits, the incorrect hard limit is set for both TSAN and MacOS. MacOS is too low by _PyOS_STACK_MARGIN_BYTES and for TSAN by half the stack size.

Linked PRs

Activity

  1. added a commit that references this issue on Oct 7, 2025
  2. StanFromIreland commented on Oct 8, 2025

    @StanFromIreland
    Member

    Triage: Can this be closed as completed?

  3. added
    pendingThe issue will be closed if no feedback is provided
    on Oct 8, 2025
  4. encukou commented on Oct 9, 2025

    @encukou
    Member

    Yeah. 3.14 doesn't have macOS-specific code, and TSAN is OK on buildbots.
    This might need a backport if a 3.14.1 fix depends on it, but let's close the issue.

  5. thesamesam commented on Oct 9, 2025

    @thesamesam
    Contributor

    We're having some issues on HPPA with the stack protection code w/ 3.14, I haven't debugged it enough to file a bug (and likely send a patch if it is what I think it is) yet, but backporting changes to the code would be appreciated in case:
    a) it fixes it, and/or
    b) to avoid complications in backporting other fixes,
    if it's known to fix some problem already.

    EDIT: .. that issue is now filed as #139914.

  6. added a commit that references this issue on Nov 17, 2025
  7. added a commit that references this issue on Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-macinterpreter-core(Objects, Python, Grammar, and Parser dirs)pendingThe issue will be closed if no feedback is providedtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions