Repository navigation
Exception thrown by shlex.quote changed in 3.14 and is not documented #138804
Description
Activity
For reference, on 3.13:
>>> import shlex ... ... shlex.quote(123) ... Traceback (most recent call last): File "<python-input-0>", line 3, in <module> shlex.quote(123) ~~~~~~~~~~~^^^^^ File "/usr/lib64/python3.13/shlex.py", line 327, in quote if _find_unsafe(s) is None: ~~~~~~~~~~~~^^^ TypeError: expected string or bytes-like object, got 'int'cc @AA-Turner
A check of the form
if isinstance(s, str | bytes):orif isinstance(s, (str, bytes)):(don't know which one is the preferred way in this module). shouldn't be too costly here so let's add it. Before, it was implicitly done in_find_unsafeas it relied onre.Pattern.search.A check of the form
if isinstance(s, str | bytes):orif isinstance(s, (str, bytes)):(don't know which one is the preferred way in this module). shouldn't be too costly here so let's add it. Before, it was implicitly done in_find_unsafeas it relied onre.Pattern.search.As
encode()is called on the argument, passing abytesobject should raise aTypeErrortoo.Thanks for the report and fix!
Bug report
Bug description:
It seems to me that #132036 not only made the import time faster but did also change the exception thrown if the arguments in shlex.quote are not of type str.
It used to be "TypeError", now it is "AttributeError" .
I am not able to find this change in the release notes or the PR.
Test code:
Test run on the shell:
CPython versions tested on:
3.10, 3.11, 3.12, 3.13, 3.14
Operating systems tested on:
macOS
Linked PRs
shlex.quote#138809shlex.quote(GH-138809) #138846