Repository navigation
Convert _interpreters to Argument Clinic #137630
Description
Feature or enhancement
Proposal:
_interpretersmodule.c currently exclusively uses PyArg_ParseTupleAndKeywords/PyArg_ParseTuple.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Activity
GH-137630: Convert ``_interpreters`` to use Argument Clinic (#137631)
GH-137630: Argument Clinic: Reduce use of 'as' for renaming in ``_int…
hnnynh commentedon Aug 15, 2025
It seems that
_interpchannelsalso needs to be worked on.Would it be okay for me to submit a PR(Convert
_interpchannelsto use Argument Clinic)?corona10 commentedon Aug 15, 2025
@AA-Turner @hnnynh is a first-time sprint participant at PyCon KR, and my colleague, it would be a good task to be familiar with the CPython code base with this task.
AA-Turner commentedon Aug 15, 2025
Thanks for the proposal both, I think we should wait here as there is an open PR waiting for Eric S.'s feedback.
Hopefully you can find another good issue to work on during the sprint @corona10 @hnnynh!
A
corona10 commentedon Aug 15, 2025
@AA-Turner Hi,
The sprint day has wrapped up today, but I think one of the main purposes of organizing sprints is to find promising contributor candidates. Would it be okay for her to follow up on the
_interpchannelsmodule if @ericsnowcurrently approves the other PR?Best,
Donghee
AA-Turner commentedon Aug 15, 2025
Converting an entire module to Argument Clinic all at once can be quite tricky,
_interpqueues.cwasn't very straightforwards (it involved writing a custom converter, which is fairly advanced even for AC). I'd prefer to do_interpchannelsmyself for this reason, and to keep consistency.For a new contributor, perhaps you would want to try converting
_json.cto Argument Clinic instead? I would happy to help review @hnnynh's PR to do this @corona10 :-)There are four functions to convert in
_json, so hopefully it should not be too hard!A
AA-Turner commentedon Aug 15, 2025
@corona10 @hnnynh see #137821
pythonGH-137630: Convert ``_interpreters`` to use Argument Clinic (py…
pythonGH-137630: Argument Clinic: Reduce use of 'as' for renaming in …
GH-137630: Convert ``_interpqueues`` to use Argument Clinic (#137685)
ZeroIntensity commentedon Sep 18, 2025
@AA-Turner Is this done?
AA-Turner commentedon Sep 18, 2025
No (
_interpchannelsremains).A