Skip to content

Calling ElementTree.write on an ElementTree instance where ElementTree._root is the wrong type causes possible data loss #135640

Closed
Closed
Calling ElementTree.write on an ElementTree instance where ElementTree._root is the wrong type causes possible data loss#135640
Labels
stdlibStandard Library Python modules in the Lib/ directorytopic-XMLtype-bugAn unexpected behavior, bug, or error

Description

@abstractedfox
abstractedfox
opened on Jun 17, 2025

Bug report

Bug description:

Example:

tree = xml.etree.ElementTree.ElementTree(element = "") # element should be an ElementTree.Element object or None
tree.write("file.xml") # This appropriately causes a traceback, but blanks file.xml if it exists

PR coming with a fix!

CPython versions tested on:

CPython main branch, 3.14

Operating systems tested on:

macOS

Linked PRs

Activity

  1. abstractedfox
    added
    type-bugAn unexpected behavior, bug, or error
    on Jun 17, 2025
  2. picnixz
    added
    stdlibStandard Library Python modules in the Lib/ directory
    extension-modulesC modules in the Modules dir
    topic-XML
    and removed
    extension-modulesC modules in the Modules dir
    on Jun 19, 2025
  3. abstractedfox
    added a commit that references this issue on Jun 22, 2025

    Make iselement stricter + incorporate feedback

    84b22d4
  4. serhiy-storchaka
    added a commit that references this issue on Jul 3, 2025

    gh-135640: Adds more type checking to ElementTree (GH-135643)

    e0245c7
  5. miss-islington
    added 2 commits that reference this issue on Jul 3, 2025

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    1b2db39

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    1dea741
  6. serhiy-storchaka
    added 2 commits that reference this issue on Jul 3, 2025

    [3.13] gh-135640: Adds more type checking to ElementTree (GH-135643) (G…

    1de8fc3

    [3.14] gh-135640: Adds more type checking to ElementTree (GH-135643) (G…

    1a4f92b

  7. serhiy-storchaka commented on Jul 3, 2025

    @serhiy-storchaka
    serhiy-storchaka
    on Jul 3, 2025
    Member

    Thank you for your contribution @abstractedfox.

    There is also other problem here. See #136231.

  8. serhiy-storchaka
    closed this as completedon Jul 3, 2025
  9. AndPuQing
    added a commit that references this issue on Jul 11, 2025

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    de025c0
  10. Pranjal095
    added a commit that references this issue on Jul 12, 2025

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    116e768
  11. picnixz
    added a commit that references this issue on Jul 13, 2025

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    5f37d25
  12. taegyunkim
    added a commit that references this issue on Aug 4, 2025

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    6f118f8
  13. Agent-Hellboy
    added a commit that references this issue on Aug 19, 2025

    pythongh-135640: Adds more type checking to ElementTree (pythonGH-135643

    0d7c01a
  14. larouxn
    added 4 commits that reference this issue on Oct 30, 2025

    Temporarily patch in libplacebo upstream Python >=3.13 compatibility fix

    fd6a7ab

    Temporarily patch in libplacebo upstream Python >=3.13 compatibility fix

    37826bc

    Upgrade libplacebo to commit including fix for Python 3.13

    ff50be1

    Upgrade libplacebo to commit including fix for Python 3.13

    c5be1bb
  15. larouxn
    added a commit that references this issue on Nov 16, 2025

    Upgrade libplacebo to commit including fix for Python 3.13

    eae35b6
  16. larouxn
    added a commit that references this issue on Dec 6, 2025

    Upgrade libplacebo to commit including fix for Python 3.13

    5a1c756
  17. larouxn
    added a commit that references this issue on Jan 3, 2026

    Upgrade libplacebo to commit including fix for Python 3.13

    e5ccb3f
  18. larouxn
    added 3 commits that reference this issue on Jan 11, 2026

    Upgrade libplacebo to commit including fix for Python 3.13

    d71aaa4

    Upgrade libplacebo to commit including fix for Python 3.13

    bde7035

    Upgrade libplacebo to commit including fix for Python 3.13

    f2c3ec3
  19. larouxn
    added a commit that references this issue on Feb 1, 2026

    Upgrade libplacebo to commit including fix for Python 3.13

    ea00dd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytopic-XMLtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions