PEP 758 changes do not have CHECK_VERSION guard for usage with ast.parse(..., feature_version=(3, 13))

Bug report

Right now this test passes:

    def test_pep758_except_without_parens(self):
        code = textwrap.dedent("""
            try:
                ...
            except ValueError, TypeError:
                ...
        """)
        ast.parse(code, feature_version=(3, 14))
        with self.assertRaises(SyntaxError):
            ast.parse(code, feature_version=(3, 13))

But, it should not pass. I have a PR ready.

Linked PRs

pythongh-133194: Add `CHECK_VERSION` to new PEP758 grammar

gh-133194: Add `CHECK_VERSION` to new PEP758 grammar (#133195)

The fix in #133195 broke valid cases. E.g.

import ast
import textwrap

code = textwrap.dedent("""
    try:
        ...
    except ValueError:
        ...
""")
ast.parse(code, feature_version=(3, 10))

now also raises a SyntaxError.

@sobolevn

@sobolevn oups, indeed. thanks for noticing. working on a fix

gh-133194: Fix regression with PEP 758 parsing on older `feature_vers…

pythongh-133194: Fix regression with PEP 758 parsing on older `featur…

Navigation Menu

Repository navigation

PEP 758 changes do not have `CHECK_VERSION` guard for usage with `ast.parse(..., feature_version=(3, 13))` #133194

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

PEP 758 changes do not have CHECK_VERSION guard for usage with ast.parse(..., feature_version=(3, 13)) #133194

Description

Bug report

Linked PRs

Activity

cdce8p commented on May 2, 2025

sobolevn commented on May 2, 2025

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

PEP 758 changes do not have `CHECK_VERSION` guard for usage with `ast.parse(..., feature_version=(3, 13))` #133194