Feature or enhancement

Proposal:

Test the header of the binary .mo file is generated correctly and is as expected for example the start of a msgfmt.py generated file:

de12 0495 0000 0000 0900 0000 1c00 0000
6400 0000 0000 0000 0000 0000 0000 0000

de12 0495 - magic number
0000 0000 - version
0900 0000 - # of entries
1c00 0000 - start of key index
6400 0000 - size of value table
0000 0000 - size of hash table
0000 0000 - offset of hash table

We currently do not test the structure of the .mo though it is partially covered as I presume the translation tests may fail but that depends on gettext.

Testing the last four will result in errors with a msgfmt.c generated general.mo as msgfmt.c generates a hash table (this will change soon I hope as we will too #131725 :-) so I think we should just test the first 3 for now and test the rest later.

I will send a pr

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

• gh-131853: test binary header in msgfmt generated file #131854
• gh-131853: Fix test_msgfmt on big-endian platforms #131879