Skip to content

We are running out of space for specialized opcodes #130574

Closed

Description

@markshannon

The opcode space is laid out as follows:

  • Normal instructions
  • Gap (>30 instructions)
  • RESUME (opcode 149)
  • Specialized instructions
  • Gap (3 instructions)
  • Instrumented instruments

If we need to add four more specializations and/or instrumented instructions we will run out of space.
The fix is obvious: Renumber RESUME to something like 128.

Linked PRs

Activity

  1. added a commit that references this issue on Feb 28, 2025
  2. picnixz commented on Mar 1, 2025

    @picnixz
    Member

    This may be a stupid question, but we would still run out of space in like.. 25 more instructions right (why actually RESUME=128 and not something else?)? what happens at this point?

  3. added a commit that references this issue on Mar 6, 2025
  4. picnixz commented on Mar 14, 2025

    @picnixz
    Member

    While my question remains unanswered, I believe that this issue can now be closed as we re-numbered the RESUME opcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions