Skip to content

doctest._load_testfile uses deprecated Loader.get_data API, it should use importlib.resources #128862

Open
Open
doctest._load_testfile uses deprecated Loader.get_data API, it should use importlib.resources#128862
Assignees
graingert
Labels
3.14bugs and security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@graingert
graingert
opened on Jan 15, 2025

Bug report

Bug description:

cpython/Lib/doctest.py

Lines 246 to 257 in ae7f621

if (loader := getattr(package, '__loader__', None)) is None:
try:
loader = package.__spec__.loader
except AttributeError:
pass
if hasattr(loader, 'get_data'):
file_contents = loader.get_data(filename)
file_contents = file_contents.decode(encoding)
# get_data() opens files as 'rb', so one must do the equivalent
# conversion as universal newlines would do.
return _newline_convert(file_contents), filename
with open(filename, encoding=encoding) as f:

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. graingert
    added
    type-bugAn unexpected behavior, bug, or error
    stdlibStandard Library Python modules in the Lib/ directory
    on Jan 15, 2025
  2. graingert
    self-assigned this
    on Jan 15, 2025
  3. graingert
    added a commit that references this issue on Jan 15, 2025

    pythongh-128862: use importlib.resources to acquire doctest resources

    2006516
  4. graingert
    added
    3.14bugs and security fixes
    on Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.14bugs and security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions