Skip to content

Protocols in wsgiref.types should use @abstractmethod #127678

Description

@srittau

Feature or enhancement

Proposal:

See this discussion in #127648 for reference.

Cc @JelleZijlstra

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Activity

  1. added
    stdlibStandard Library Python modules in the Lib/ directory
    on Dec 6, 2024
  2. AlexWaygood commented on Dec 6, 2024

    @AlexWaygood
    Member

    If it's accepted, I'm not sure this would be backportable -- it could be considered a breaking change. What if a class inherits from one of these protocols but doesn't override one of the methods you're proposing to make abstract?

  3. srittau commented on Dec 6, 2024

    @srittau
    ContributorAuthor

    That is indeed a breaking change, and probably one where there's not good deprecation path. But I also assume that the impact is rather small and would point to actual bugs. But checking the top 1000 or so packages for this would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytopic-typingtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions