Skip to content

configure is checking for ttyname but code is using ttyname_r #127614

Closed
#128503
Closed
configure is checking for ttyname but code is using ttyname_r#127614
#128503
Labels
buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

Description

@glebm
glebm
opened on Dec 4, 2024

Bug report

Bug description:

PR #14868 by @chibby0ne changed the code to use ttyname_r but the configure script is checking for ttyname.

There are some old systems, such as OSX Tiger, that don't have ttyname_r (at least not by default), so it'd be nice if ttyname_r was checked for separately with fallback to ttyname.

CPython versions tested on:

3.11, 3.12

Operating systems tested on:

macOS

Linked PRs

Activity

  1. glebm
    added
    type-bugAn unexpected behavior, bug, or error
    on Dec 4, 2024
  2. glebm
    added 4 commits that reference this issue on Dec 4, 2024

    python39+: fix build on Tiger

    2e66f5c

    python39+: fix build on Tiger

    6aab3cd

    python39+: fix build on Tiger

    ca9071d

    python39+: fix build on Tiger

    009bfc7
  3. picnixz
    added
    buildThe build process and cross-build
    on Dec 5, 2024
  4. glebm
    added 2 commits that reference this issue on Dec 6, 2024

    python39+: fix build on Tiger

    14823fc

    python39+: fix build on tiger gcc14

    318232f
  5. jmroot
    added a commit that references this issue on Dec 7, 2024

    python39+: fix build on tiger gcc14

    a6870ef

  6. erlend-aasland commented on Jan 4, 2025

    @erlend-aasland
    erlend-aasland
    on Jan 4, 2025
    Contributor

    Mac OS X Tiger is not supported; I'm not sure it is worth it to add a fallback to ttyname. I agree, though, that we should fix the build dependency check.

  7. erlend-aasland
    added a commit that references this issue on Jan 4, 2025

    pythongh-127614: Correctly check for ttyname_r() in configure

    f25911a
  8. erlend-aasland
    linked a pull request that will close this issuegh-127614: Correctly check for ttyname_r() in configure #128503on Jan 4, 2025
  9. erlend-aasland
    added a commit that references this issue on Jan 7, 2025

    gh-127614: Correctly check for ttyname_r() in configure (#128503)

    e08b282
  10. erlend-aasland
    closed this as completedin #128503on Jan 7, 2025
  11. erlend-aasland
    added a commit that references this issue on Jan 7, 2025

    [3.13] pythongh-127614: Correctly check for ttyname_r() in configure (p…

    cf1909a

  12. erlend-aasland commented on Jan 7, 2025

    @erlend-aasland
    erlend-aasland
    on Jan 7, 2025
    Contributor

    Thanks for the report, @glebm

  13. erlend-aasland
    added a commit that references this issue on Jan 7, 2025

    [3.12] gh-127614: Correctly check for ttyname_r() in configure (#128503…

    6b33719

  14. glebm commented on Jan 7, 2025

    @glebm
    glebm
    on Jan 7, 2025
    Author

    Thanks for the fix!

  15. srinivasreddy
    added a commit that references this issue on Jan 8, 2025

    pythongh-127614: Correctly check for ttyname_r() in configure (python…

    ebc1cc2
  16. erlend-aasland
    added a commit that references this issue on Jan 11, 2025

    [3.13] gh-127614: Correctly check for ttyname_r() in configure (#128503…

    436064a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildThe build process and cross-buildtype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions