Skip to content

Outdated socket.NETLINK_* constants  #127072

Closed
Closed
Outdated socket.NETLINK_* constants #127072
Labels
OS-linuxextension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

Description

@tungol
tungol
opened on Nov 20, 2024

Feature or enhancement

Proposal:

When working through the constants in socket for typeshed, I found that these appear to be obsolete:

NETLINK_ARPD: int  # linux 2.0 to 2.6.12 (EOL August 2005)
NETLINK_ROUTE6: int  # linux 2.2 to 2.6.12 (EOL August 2005)
NETLINK_SKIP: int  # linux 2.0 to 2.6.12 (EOL August 2005)
NETLINK_TAPBASE: int  # linux 2.2 to 2.6.12 (EOL August 2005)
NETLINK_TCPDIAG: int  # linux 2.6.0 to 2.6.13 (EOL December 2005)
NETLINK_W1: int  # linux 2.6.13 to 2.6.17 (EOL October 2006)

The netlink constants are defined in include/linux/netlink.h on linux 2.0 to 3.6. Starting in 3.7 they moved to include/uapi/linux/netlink.h. I've annotated these with the versions of linux where I was able to find them, and confirmed that they're not present in FreeBSD's Netlink implementation either.

I suspect these can be safely removed, but I'm not terribly familiar with Netlink myself.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. tungol
    added
    type-featureA feature request or enhancement
    on Nov 20, 2024
  2. picnixz
    added
    extension-modulesC modules in the Modules dir
    on Nov 21, 2024
  3. AA-Turner
    added
    OS-linux
    on Nov 22, 2024

  4. rruuaanng commented on Nov 23, 2024

    @rruuaanng
    rruuaanng
    on Nov 23, 2024
    Contributor

    If you wish, they can be removed. Currently they are no longer present in uapi/linux/netlink.h in the master branch. But if I could, I'd like this to be given to me ;)

  5. tungol commented on Nov 23, 2024

    @tungol
    tungol
    on Nov 23, 2024
    ContributorAuthor

    I have no intention to open an MR related to this issue myself, if that's what you mean. If you know what the correct thing to do here is, please go ahead!

    If you haven't seen it, you might also be interested in this related issue I opened: #127069

  6. rruuaanng commented on Nov 25, 2024

    @rruuaanng
    rruuaanng
    on Nov 25, 2024
    Contributor

    I'll submit a PR to remove them soon. Netlink first appeared in linux1.3, and if I remember correctly. As far as I can remember, no other os to support netlink (FreeBSD only partially compatible.)

  7. gpshead
    added a commit that references this issue on Nov 27, 2024

    gh-127072: Remove outdated `socket.NETLINK_*` constants. (GH-127256)

    6d3b520

  8. picnixz commented on Nov 27, 2024

    @picnixz
    picnixz
    on Nov 27, 2024
    Member

    Closing since completed.

  9. picnixz
    closed this as completedon Nov 27, 2024
  10. ebonnal
    added a commit that references this issue on Jan 12, 2025

    pythongh-127072: Remove outdated `socket.NETLINK_*` constants. (pytho…

    1eadc0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    OS-linuxextension-modulesC modules in the Modules dirtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions