Skip to content

Crash in _PyXI_ApplyErrorCode() #126986

Closed
Closed
Crash in _PyXI_ApplyErrorCode()#126986
Labels
3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-subinterpreterstype-crashA hard crash of the interpreter, possibly with a core dump

Description

@ericsnowcurrently
ericsnowcurrently
opened on Nov 18, 2024

Crash report

Bug description:

This is a problem in Python/crossinterp.c, as exposed by the _interpreters module.

reproducer:

  1. interp is running as "main" in thread 1
  2. thread 2 calls _PyXI_Enter(), which emits the _PyXI_ERR_ALREADY_RUNNING error code
  3. thread 1 finishes
  4. thread 2 calls _PyXI_ApplyError()
  5. _PyXI_ApplyError() calls _PyInterpreterState_FailIfNotRunning() to raise the exception, but it doesn't raise anything

I noticed this while working on gh-126914.

CPython versions tested on:

3.14

Operating systems tested on:

No response

Linked PRs

Activity

  1. ericsnowcurrently
    added
    interpreter-core(Objects, Python, Grammar, and Parser dirs)
    type-crashA hard crash of the interpreter, possibly with a core dump
    topic-subinterpreters
    3.14bugs and security fixes
    on Nov 18, 2024
  2. github-project-automation
    added this to Subinterpreterson Nov 18, 2024
  3. github-project-automation
    moved this to Todo in Subinterpreterson Nov 18, 2024
  4. ericsnowcurrently
    added a commit that references this issue on Nov 19, 2024

    gh-126986: Drop _PyInterpreterState_FailIfNotRunning() (gh-126988)

    d6b3e78

  5. ZeroIntensity commented on Nov 19, 2024

    @ZeroIntensity
    ZeroIntensity
    on Nov 19, 2024
    Member

    Affecting 3.13(t) as well:

    $ ./python x.py
python: Python/crossinterp.c:988: _PyXI_ApplyErrorCode: Assertion `_PyInterpreterState_IsRunningMain(interp)' failed.
  6. miss-islington
    added a commit that references this issue on Nov 19, 2024

    pythongh-126986: Drop _PyInterpreterState_FailIfNotRunning() (pythong…

    73a3075
  7. ZeroIntensity
    added
    3.13only security fixes
    on Nov 19, 2024
  8. ericsnowcurrently
    added 2 commits that reference this issue on Nov 21, 2024

    pythongh-126986: Drop _PyInterpreterState_FailIfNotRunning() (pythong…

    ad3e39d

    [3.13] gh-126986: Stop Using _PyInterpreterState_FailIfNotRunning() (g…

    8cdd636
  9. ericsnowcurrently
    closed this as completedon Nov 21, 2024
  10. github-project-automation
    moved this from Todo to Done in Subinterpreterson Nov 21, 2024
  11. ebonnal
    added a commit that references this issue on Jan 12, 2025

    pythongh-126986: Drop _PyInterpreterState_FailIfNotRunning() (pythong…

    a5fd66b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.13only security fixes3.14bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-subinterpreterstype-crashA hard crash of the interpreter, possibly with a core dump

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions