You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The python PEG parser generator doesn't allow f-strings anymore in actions #125588
Just ran into this today when trying to test a clean build of main on my buildbot. My buildbot has a system python of 3.11, but with this change, it needs to be 3.12+ otherwise there's an exception on non-existent FSTRING_* attributes in the token module. The issue hasn't yet presented itself on any of the regular builder builds, I guess due to re-generation not usually being necessary, but presumably it will the next time the grammar is touched.
It appears 3.10+ is the current minimum enforced by find_python.bat under Windows (and I believe configure under Linux). I can fix things by adding a default "None" parameter to the new getattr() calls (together with the existing "if not" checks) but am unsure if this would still produce the right final output, or if the minimum system python version just needs to be bumped.
Just ran into this today when trying to test a clean build of main on my buildbot. My buildbot has a system python of 3.11, but with this change, it needs to be 3.12+ otherwise there's an exception on non-existent FSTRING_* attributes in the token module. The issue hasn't yet presented itself on any of the regular builder builds, I guess due to re-generation not usually being necessary, but presumably it will the next time the grammar is touched.
I think that has been an oversight in #125589 I will fix it soon
Activity
pythongh-125588: Teach the python PEG generator the new f-string tokens
pythongh-125588: Teach the python PEG generator the new f-string tokens
pythongh-125588: Teach the python PEG generator the new f-string tokens
Merge branch 'main' into pythongh-125588
[-]The python PEG parser generator doesn't allow strings anymore in actions[/-][+]The python PEG parser generator doesn't allow f-strings anymore in actions[/+]pythongh-125588: Teach the python PEG generator the new f-string tokens
pythongh-125588: Teach the python PEG generator the new f-string tokens
Merge branch 'main' into pythongh-125588
gh-125588: Teach the python PEG generator the new f-string tokens (#1…
db3l commentedon Nov 22, 2024
Just ran into this today when trying to test a clean build of main on my buildbot. My buildbot has a system python of 3.11, but with this change, it needs to be 3.12+ otherwise there's an exception on non-existent FSTRING_* attributes in the token module. The issue hasn't yet presented itself on any of the regular builder builds, I guess due to re-generation not usually being necessary, but presumably it will the next time the grammar is touched.
It appears 3.10+ is the current minimum enforced by find_python.bat under Windows (and I believe configure under Linux). I can fix things by adding a default "None" parameter to the new getattr() calls (together with the existing "if not" checks) but am unsure if this would still produce the right final output, or if the minimum system python version just needs to be bumped.
pythongh-125588: Teach the python PEG generator the new f-string toke…
pablogsal commentedon Dec 15, 2024
I think that has been an oversight in #125589 I will fix it soon
pythongh-125588: Allow to regenerate the parser with Python < 3.12
pythongh-125588: Allow to regenerate the parser with Python < 3.12
gh-125588: Allow to regenerate the parser with Python < 3.12 (#127969)
pythongh-125588: Allow to regenerate the parser with Python < 3.12 (p…
pythongh-125588: Teach the python PEG generator the new f-string toke…