Make ctrl-c interrupt threading.Lock.acquire() on Windows

@pitrou

Feature or enhancement

Since Python 3.2, pressing ctrl-c (SIGINT) interrupts threading.Lock.acquire() on POSIX platforms, including Linux and macOS. However, this does not work on Windows.

Now that threading.Lock and threading.RLock use PyMutex and _PyRecursiveMutex internally, this should be a lot easier to implement efficiently.

Linked PRs

gh-125541: Make Ctrl-C interrupt threading.Lock.acquire() on Windows #125546

You mean here

cpython/Python/parking_lot.c

Line 114 in aac89b5

wait = WaitForSingleObjectEx(sema->platform_sem, millis, FALSE);

?

Yes, we can use WaitForMultipleObjectsEx() with _PyOS_SigintEvent() there without performance implications because that is the slow path that's only taken if the thread is about to block.

pythongh-125541: Make Ctrl-C interrupt `threading.Lock.acquire()` on …

gh-125541: Make Ctrl-C interrupt `threading.Lock.acquire()` on Windows (

pythongh-125541: Make Ctrl-C interrupt `threading.Lock.acquire()` on …

Navigation Menu

Repository navigation

Make `ctrl-c` interrupt `threading.Lock.acquire()` on Windows #125541

Feature or enhancement

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Make ctrl-c interrupt threading.Lock.acquire() on Windows #125541

Description

Feature or enhancement

Linked PRs

Activity

pitrou commented on Oct 15, 2024

colesbury commented on Oct 15, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Make `ctrl-c` interrupt `threading.Lock.acquire()` on Windows #125541