3.10's make regen-pegen-metaparser fails with 3.12+ #125529

Activity

1. encukou

   added

   3.10 (EOL)end of lifeend of life

   topic-parser

   on Oct 15, 2024
2. lysnikolaou commented on Oct 15, 2024

   

   lysnikolaou

   on Oct 15, 2024

   Last edited by lysnikolaou

   Member

   More actions

   That's because of PEP 701 and the fact that f-strings are no longer STRING tokens (grammar actions need to be valid Python tokens and the accepted tokens need to be listed in the actions mini-grammar).

   This patch solves the issue, though I don't know how we would fix this now that 3.10 is security-only:

   diff --git a/Tools/peg_generator/pegen/grammar_parser.py b/Tools/peg_generator/pegen/grammar_parser.py
   index 892df5cf8cc..de735649d46 100644
   --- a/Tools/peg_generator/pegen/grammar_parser.py
   +++ b/Tools/peg_generator/pegen/grammar_parser.py
   @@ -420,7 +420,7 @@ def named_item(self) -> Optional[NamedItem]:
   +++ b/Tools/peg_generator/pegen/grammar_parser.py
   @@ -420,7 +420,7 @@ def named_item(self) -> Optional[NamedItem]:
                and
                (item := self.item())
            ):
   -            return NamedItem ( name . string , item , f"{type.string}*" )
   +            return NamedItem ( name . string , item , type . string + "*" )
            self.reset(mark)
            if cut: return None
            cut = False
   diff --git a/Tools/peg_generator/pegen/metagrammar.gram b/Tools/peg_generator/pegen/metagrammar.gram
   index bb4355fd189..77695d5e0a9 100644
   --- a/Tools/peg_generator/pegen/metagrammar.gram
   +++ b/Tools/peg_generator/pegen/metagrammar.gram
   @@ -84,7 +84,7 @@ items[NamedItemList]:
        | named_item { [named_item] }
    
    named_item[NamedItem]:
   -    | NAME '[' type=NAME '*' ']' '=' ~ item {NamedItem(name.string, item, f"{type.string}*")}
   +    | NAME '[' type=NAME '*' ']' '=' ~ item {NamedItem(name.string, item, type.string+"*")}
        | NAME '[' type=NAME ']' '=' ~ item {NamedItem(name.string, item, type.string)}
        | NAME '=' ~ item {NamedItem(name.string, item)}
        | item {NamedItem(None, item)}
3. encukou commented on Oct 16, 2024

   

   encukou

   on Oct 16, 2024

   MemberAuthor

   More actions

   Thank you!

   Ultimately that's the release manager's call, but I think this is the right solution. I'll prepare a PR and write some reasoning there.

   👍React with 👍1Reacted by Lysandros Nikolaou
4. encukou

   added a commit that references this issue on Oct 16, 2024

   [3.10] pythongh-125529: Avoid f-strings in the metagrammar

   ...

   697a077
5. pablogsal

   added a commit that references this issue on Oct 22, 2024

   [3.10] gh-125529: Avoid f-strings in the metagrammar (#125582)

   ...

   6a2f12a
6. Eclips4

   closed this as completedon Dec 14, 2024