Skip to content

Incorrect slot check: typo in __dictoffset__ #123935

Closed
Closed
Incorrect slot check: typo in __dictoffset__#123935
Assignees
sobolevn
Labels
3.12only security fixes3.13only security fixesstdlibStandard Library Python modules in the Lib/ directorytopic-dataclassestype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Sep 11, 2024

Bug report

I made a typo that made it into the final code:

cpython/Lib/dataclasses.py

Lines 1211 to 1212 in 00ffdf2

if getattr(cls, '__dictrefoffset__', -1) != 0:
slots.append('__dict__')

It should had been __dictoffset__ not __dictrefoffset__.

Fixing plan:

  • Add tests for C types with __dictoffset__, so it won't happen again :)
  • Fix the typo

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    stdlibStandard Library Python modules in the Lib/ directory
    topic-dataclasses
    on Sep 11, 2024
  2. sobolevn
    self-assigned this
    on Sep 11, 2024

  3. picnixz commented on Sep 11, 2024

    @picnixz
    picnixz
    on Sep 11, 2024
    Member

    Out of curiosity... how did you find it?

  4. sobolevn commented on Sep 11, 2024

    @sobolevn
    sobolevn
    on Sep 11, 2024
    MemberAuthor

    I have a telegram channel, where I post different Python-related posts. Today I posted about how slots work in dataclasses. And one of my readers found this typo :)

  5. sobolevn
    added 2 commits that reference this issue on Sep 11, 2024

    pythongh-123935: Fix typo in `_get_slots` in `dataclasses.py`

    d085d00

    pythongh-123935: Fix typo in `_get_slots` in `dataclasses.py`

    4bf23e6
  6. sobolevn
    changed the title [-]Incorrect slot check: typo in `__dictoffest__`[/-] [+]Incorrect slot check: typo in `__dictoffset__`[/+] on Sep 11, 2024
  7. vstinner
    added
    needs backport to 3.12only security fixes
    needs backport to 3.13only security fixes
    on Sep 11, 2024
  8. picnixz
    added
    3.12only security fixes
    3.13only security fixes
    and removed
    needs backport to 3.12only security fixes
    needs backport to 3.13only security fixes
    on Sep 11, 2024
  9. sobolevn
    added a commit that references this issue on Sep 12, 2024

    gh-123935: Fix typo in `_get_slots` in `dataclasses.py` (#123941)

    ac918cc
  10. miss-islington
    added 2 commits that reference this issue on Sep 12, 2024

    pythongh-123935: Fix typo in `_get_slots` in `dataclasses.py` (python…

    883f1bd

    pythongh-123935: Fix typo in `_get_slots` in `dataclasses.py` (python…

    bae0c1c
  11. sobolevn
    added a commit that references this issue on Sep 12, 2024

    [3.12] gh-123935: Fix typo in `_get_slots` in `dataclasses.py` (GH-12…

    9e93556
  12. Yhg1s
    added a commit that references this issue on Dec 3, 2024

    [3.13] gh-123935: Fix typo in `_get_slots` in `dataclasses.py` (GH-12…

    ae3f347

  13. hugovk commented on Jan 7, 2025

    @hugovk
    hugovk
    on Jan 7, 2025
    Member

    PR merged and backported 🚀

  14. hugovk
    closed this as completedon Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.12only security fixes3.13only security fixesstdlibStandard Library Python modules in the Lib/ directorytopic-dataclassestype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions