Skip to content

cursesmodule uses winobj which might be NULL #123913

Closed as not planned
Closed as not planned
cursesmodule uses winobj which might be NULL#123913
Assignees
sobolevn
Labels
extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Description

@sobolevn
sobolevn
opened on Sep 10, 2024

Bug report

Here's the problematic code:

cpython/Modules/_cursesmodule.c

Lines 3365 to 3367 in a2d0818

winobj = (PyCursesWindowObject *)PyCursesWindow_New(win, NULL);
screen_encoding = winobj->encoding;
return (PyObject *)winobj;

Why is it problematic? Because PyCursesWindow_New can return NULL here:

cpython/Modules/_cursesmodule.c

Lines 708 to 712 in a2d0818

if (wo->encoding == NULL) {
Py_DECREF(wo);
PyErr_NoMemory();
return NULL;
}

So, winobj->encoding of NULL is not good :(

I will send a PR.

Linked PRs

Activity

  1. sobolevn
    added
    type-bugAn unexpected behavior, bug, or error
    extension-modulesC modules in the Modules dir
    on Sep 10, 2024
  2. sobolevn
    self-assigned this
    on Sep 10, 2024
  3. sobolevn
    added a commit that references this issue on Sep 10, 2024

    pythongh-123913: Fix `NULL` handling in `_curses_initscr_impl` of `_c…

    c5e0c55

  4. sobolevn commented on Sep 10, 2024

    @sobolevn
    sobolevn
    on Sep 10, 2024
    MemberAuthor

    Will be solved in #123910
    Closing as a duplicate.

  5. sobolevn
    closed this as not plannedon Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions