Skip to content

test_sqlite3/test_dump.py Fails if SQLite Foreign Keys Enabled #123849

Closed
Closed
test_sqlite3/test_dump.py Fails if SQLite Foreign Keys Enabled#123849
Labels
testsTests in the Lib/test dirtopic-sqlite3type-bugAn unexpected behavior, bug, or error

Description

@Derothin
Derothin
opened on Sep 8, 2024

Bug report

Bug description:

Just compiled 3.13.0rc2 today and ran into this issue with test_sqlite3. A commit added an intentional foreign key violation in test_dump.py, but the test doesn't consider that SQLite may have been compiled with foreign keys enabled by default. Just needs to have that turned off for the test.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs

Activity

  1. Derothin
    added
    type-bugAn unexpected behavior, bug, or error
    on Sep 8, 2024
  2. Eclips4
    added
    testsTests in the Lib/test dir
    topic-sqlite3
    on Sep 8, 2024
  3. felixxm
    added a commit that references this issue on Sep 9, 2024

    pythongh-123849: Fix DumpTests.test_table_dump() crash on SQLite when…

    b9f9c58
  4. erlend-aasland
    added 2 commits that reference this issue on Oct 8, 2024

    Merge branch 'main' into pythongh-123849

    7b67345

    gh-123849: Fix test_sqlite3.test_table_dump when foreign keys are ena…

    14b44c5
  5. miss-islington
    added a commit that references this issue on Oct 8, 2024

    pythongh-123849: Fix test_sqlite3.test_table_dump when foreign keys a…

    0b7de29
  6. efimov-mikhail
    added a commit that references this issue on Oct 9, 2024

    pythongh-123849: Fix test_sqlite3.test_table_dump when foreign keys a…

    5f4da9b
  7. erlend-aasland
    added a commit that references this issue on Oct 13, 2024

    [3.13] gh-123849: Fix test_sqlite3.test_table_dump when foreign keys …

    98655ce
  8. erlend-aasland
    closed this as completedon Oct 13, 2024

  9. erlend-aasland commented on Oct 13, 2024

    @erlend-aasland
    erlend-aasland
    on Oct 13, 2024
    Contributor

    Fixed in main and the 3.13 branch. Thanks for the report, @Derothin, and thanks for the fix, @felixxm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtopic-sqlite3type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions