Skip to content

_tkinter leaks type references on initialization #123504

Closed
Closed
_tkinter leaks type references on initialization#123504
Labels
extension-modulesC modules in the Modules dirtopic-tkintertype-bugAn unexpected behavior, bug, or error

Description

@ZeroIntensity
ZeroIntensity
opened on Aug 30, 2024

Bug report

Bug description:

Reproducer:

$ ./python -Xshowrefcount -c "import tkinter"

Seems to be caused by the use of AddObjectRef on a strong reference in the _tkinter initialization function, causing a double Py_INCREF.

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

  1. ZeroIntensity
    added
    type-bugAn unexpected behavior, bug, or error
    on Aug 30, 2024
  2. picnixz
    added
    extension-modulesC modules in the Modules dir
    topic-tkinter
    on Aug 30, 2024
  3. vstinner
    added a commit that references this issue on Sep 3, 2024

    gh-123504: Fix reference leak in finalization of `_tkinter` (#123505)

    a8bc036
  4. ZeroIntensity
    closed this as completedon Sep 3, 2024
  5. serhiy-storchaka
    reopened this on Sep 4, 2024

  6. serhiy-storchaka commented on Sep 4, 2024

    @serhiy-storchaka
    serhiy-storchaka
    on Sep 4, 2024
    Member

    #123505 was not correct. You need to:

    1. Restore m_size.
    2. Define m_travel.

  7. ZeroIntensity commented on Sep 4, 2024

    @ZeroIntensity
    ZeroIntensity
    on Sep 4, 2024
    MemberAuthor

    I'll submit a PR within in the hour, sorry!

  8. serhiy-storchaka commented on Sep 4, 2024

    @serhiy-storchaka
    serhiy-storchaka
    on Sep 4, 2024
    Member

    It would also be nice if one of the subinterpreters experts would take a look at this change.

  9. vstinner
    added a commit that references this issue on Sep 4, 2024

    gh-123504: Fix regression in `_tkinter` initializer (#123662)

    2daed5f
  10. ZeroIntensity
    closed this as completedon Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    extension-modulesC modules in the Modules dirtopic-tkintertype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions