Repository navigation
Compilation is broken with HAVE_DYNAMIC_LOADING=0 #122907
Description
Bug report
Bug description:
When compiling for Wasm with --disable-wasm-dynamic-linking, we end up with HAVE_DYNAMIC_LOADING=0, which is currently broken with the following linking errors:
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_info_init_for_builtin
wasm-ld: error: Python/import.o: undefined symbol: _PyImport_RunModInitFunc
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_apply_error
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_clear
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_clear
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_info_clear
wasm-ld: error: Python/import.o: undefined symbol: _PyImport_RunModInitFunc
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_apply_error
wasm-ld: error: Python/import.o: undefined symbol: _Py_ext_module_loader_result_clear
I believe its a regression introduced in 529a160.
@ericsnowcurrently, would you be able to take a look into fixing this?
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Activity
ericsnowcurrently commentedon Aug 12, 2024
I'll take a look.
brettcannon commentedon Aug 12, 2024
Is this for Emscripten of WASI? If it's for the former it's no longer officially supported as of CPython 3.13 (code for Emsripten will start being removed in CPython 3.14/main, I just haven't gotten around to doing the removal).
ericsnowcurrently commentedon Aug 12, 2024
The problem manifests with
HAVE_DYNAMIC_LOADINGnot set, regardless of any WASM-related build. I'll get builds without dynamic loading working again with a minimal change, but there are broader deficiencies to address. See gh-122950.gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952)
pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…
pythongh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (pythong…
[3.13] gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952
ZeroIntensity commentedon Jan 11, 2025
Doing some triaging. Is this all good to close?
freakboy3742 commentedon Jan 11, 2025
My read is that it is good to close; there's still a related issue, but that's being tracked by #122950.
Also - for the benefit of posterity, Emscripten support is back on for 3.14 (or, at least, myself and @hoodmane... mostly @hoodmane) are trying to restore it to Tier 3.