Skip to content

Dead code in ceval_macros.h and ceval_gil.c #122860

Closed
Closed
Dead code in ceval_macros.h and ceval_gil.c#122860

Description

@colesbury
colesbury
opened on Aug 9, 2024

The _Py_atomic_load_relaxed_int32 macro is no longer used:

cpython/Python/ceval_macros.h

Lines 378 to 383 in d323997

// GH-89279: Force inlining by using a macro.
#if defined(_MSC_VER) && SIZEOF_INT == 4
#define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) (assert(sizeof((ATOMIC_VAL)->_value) == 4), *((volatile int*)&((ATOMIC_VAL)->_value)))
#else
#define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) _Py_atomic_load_relaxed(ATOMIC_VAL)
#endif

cpython/Python/ceval_gil.c

Lines 52 to 57 in d323997

// GH-89279: Force inlining by using a macro.
#if defined(_MSC_VER) && SIZEOF_INT == 4
#define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) (assert(sizeof((ATOMIC_VAL)->_value) == 4), *((volatile int*)&((ATOMIC_VAL)->_value)))
#else
#define _Py_atomic_load_relaxed_int32(ATOMIC_VAL) _Py_atomic_load_relaxed(ATOMIC_VAL)
#endif

Linked PRs

Activity

  1. colesbury
    added a commit that references this issue on Aug 9, 2024

    pythongh-122860: Remove unused macro `_Py_atomic_load_relaxed_int32`

    14980f0

  2. neonene commented on Aug 10, 2024

    @neonene
    neonene
    on Aug 10, 2024
    Contributor

    They were added by #32387. I can confirm that the new _Py_atomic_* functions are all inlined by MSVC (Release, PGO).

  3. kumaraditya303
    added a commit that references this issue on Aug 11, 2024

    gh-122860: Remove unused macro `_Py_atomic_load_relaxed_int32` (#122861)

    1069190
  4. kumaraditya303
    closed this as completedon Aug 11, 2024
  5. blhsing
    added a commit that references this issue on Aug 22, 2024

    pythongh-122860: Remove unused macro `_Py_atomic_load_relaxed_int32` (p…

    fa81978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions