You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Significant performance degradation in the macOS build #122832
The other report shows a specific piece of code that runs a little slower and could reasonably be attributed to a skipped PGO path or build noise. This report shows degradation across the board. Local variable reads are 4x slower. This isn't minor.
The other report used a local build which would be affected by many factors. This report uses the official python.org builds.
The other report used an alpha version. This report focuses on a release-candidate which means that this is what we're about to ship. That makes the level of severity more important.
Rather than thinking about dismissing this as a duplicate, a better question is whether it should be marked as a release-blocker.
The full pyperformance suite has been run in the other issue, comparing 3.13.0rc1 and 3.12.4 and showed the RC is some 9% slower. See #122580 (comment)
Yes, I think it's a release blocker. There's a possible solution in the other issue, building with different flags.
BTW, thanks again, @rhettinger, for implementing that useful benchmark. I had been using it already in investigating the other report which was also against the python.org builds, later diverging into local test builds.
The other report shows a specific piece of code that runs a little slower and could reasonably be attributed to a skipped PGO path or build noise. This report shows degradation across the board. Local variable reads are 4x slower. This isn't minor.
The other report used a local build which would be affected by many factors. This report uses the official python.org builds.
The other report used an alpha version. This report focuses on a release-candidate which means that this is what we're about to ship. That makes the level of severity more important.
Rather than thinking about dismissing this as a duplicate, a better question is whether it should be marked as a release-blocker.
The other report shows a specific piece of code that runs a little slower and could reasonably be attributed to a skipped PGO path or build noise. This report shows degradation across the board. Local variable reads are 4x slower. This isn't minor.
The other report used a local build which would be affected by many factors. This report uses the official python.org builds.
The other report used an alpha version. This report focuses on a release-candidate which means that this is what we're about to ship. That makes the level of severity more important.
Rather than thinking about dismissing this as a duplicate, a better question is whether it should be marked as a release-blocker.
Actually, my report used the official installers from Python.org, and focused on the release candidate as well. So, they can be seen as the same overall issue. Thanks for the benchmark to help this out.
Thanks again for the extremely useful data and the heads-up. Since the performance degradation here appears to the same root cause and solution (which will be available in 3.13.0rc2) as that noted in #122580, I am going to close this as a duplicate and consolidate the discussion there.
Activity
hugovk commentedon Aug 8, 2024
Sound like a duplicate of #122580.
rhettinger commentedon Aug 8, 2024
There are key differences.
The other report shows a specific piece of code that runs a little slower and could reasonably be attributed to a skipped PGO path or build noise. This report shows degradation across the board. Local variable reads are 4x slower. This isn't minor.
The other report used a local build which would be affected by many factors. This report uses the official
python.orgbuilds.The other report used an alpha version. This report focuses on a release-candidate which means that this is what we're about to ship. That makes the level of severity more important.
Rather than thinking about dismissing this as a duplicate, a better question is whether it should be marked as a release-blocker.
ned-deily commentedon Aug 8, 2024
Thanks for the additional data points. I think we were considering the other issue to be a release blocker and should have labeled it as such.
hugovk commentedon Aug 8, 2024
The full pyperformance suite has been run in the other issue, comparing 3.13.0rc1 and 3.12.4 and showed the RC is some 9% slower. See #122580 (comment)
Yes, I think it's a release blocker. There's a possible solution in the other issue, building with different flags.
ned-deily commentedon Aug 8, 2024
BTW, thanks again, @rhettinger, for implementing that useful benchmark. I had been using it already in investigating the other report which was also against the python.org builds, later diverging into local test builds.
hg0428 commentedon Aug 9, 2024
Actually, my report used the official installers from Python.org, and focused on the release candidate as well. So, they can be seen as the same overall issue. Thanks for the benchmark to help this out.
ned-deily commentedon Sep 3, 2024
Thanks again for the extremely useful data and the heads-up. Since the performance degradation here appears to the same root cause and solution (which will be available in 3.13.0rc2) as that noted in #122580, I am going to close this as a duplicate and consolidate the discussion there.
rhettinger commentedon Sep 7, 2024
Just tested 3.13rc2 and everything is fixed. Thank you.