Skip to content

Accuracy issues of sum() specialization for floats/complexes #122234

Description

@skirpichev

Bug report

Bug description:

Unfortunately, #121176 was merged with a bug:

cpython/Python/bltinmodule.c

Lines 2749 to 2755 in e968121

if (PyFloat_Check(item)) {
double value = PyFloat_AS_DOUBLE(item);
re_sum.hi += value;
im_sum.hi += 0.0;
_Py_DECREF_SPECIALIZED(item, _PyFloat_ExactDealloc);
continue;
}

L2751 lacks cs_add(). Sorry for that. Reproducer: sum([2j, 1., 10E100, 1., -10E100]) (should be 2+2j). I'll provide a patch.

But maybe cases for integer arguments also should use compensated summation? E.g.:

cpython/Python/bltinmodule.c

Lines 2689 to 2698 in e968121

if (PyLong_Check(item)) {
long value;
int overflow;
value = PyLong_AsLongAndOverflow(item, &overflow);
if (!overflow) {
re_sum.hi += (double)value;
Py_DECREF(item);
continue;
}
}

on L2694 (and use PyLong_AsDouble()). An example:

>>> sum([1.0, 10E100, 1.0, -10E100])
2.0
>>> sum([1.0, 10**100, 1.0, -10**100])  # huh?
0.0

I would guess, that integer values in this case are treated as exact and they are allowed to smash floating-point result to garbage. But... This looks as a bug for me. fsum() also chooses 2.0:

>>> math.fsum([1.0, 10**100, 1.0, -10**100])
2.0

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

Activity

skirpichev commented on Jul 24, 2024

@skirpichev
MemberAuthor

CC @rhettinger for the second part (integer values). Is this an issue or a feature?

picnixz commented on Jul 24, 2024

@picnixz
Member

Actually, even without the sum, we have:

>>> x = 10 ** 100
>>> 1.0 + x + 1.0 - x
0.0

skirpichev commented on Jul 24, 2024

@skirpichev
MemberAuthor

@picnixz, that's a feature.

Ok, it seems that in the second case PyLong_AsLongAndOverflow() just overflows and we fallback to the generic sum. That's something copied from the specialization for integers (in 8ce8a78) and it wasn't changed in #100426. Maybe it should?

skirpichev commented on Jul 24, 2024

@skirpichev
MemberAuthor

Hmm, with PyLong_AsDouble() + compensated summation it's even faster!

./python -m timeit -r11 -s 'xs=[1.0, 10**100, 1.0, -10**100]' 'sum(xs)'
500000 loops, best of 11: 634 nsec per loop

while in the main:

$ ./python -m timeit -r11 -s 'xs=[1.0, 10**100, 1.0, -10**100]' 'sum(xs)'
500000 loops, best of 11: 801 nsec per loop
added a commit that references this issue on Jul 24, 2024

skirpichev commented on Jul 24, 2024

@skirpichev
MemberAuthor

PR is ready for review: #122236

It combines fixes for floats and integers. If second case requires more discussion or is "a feature", I can quickly revert that part.

added a commit that references this issue on Jul 29, 2024
added a commit that references this issue on Jul 29, 2024

encukou commented on Jul 29, 2024

@encukou
Member

The added error returns leak references. This was caught by the noGIL refleak buildbot (which runs more often than refleaks for regular-builds): https://buildbot.python.org/#/builders/1226/builds/2352/steps/6/logs/stdio

Eclips4 commented on Jul 29, 2024

@Eclips4
Member

The added error returns leak references. This was caught by the noGIL refleak buildbot (which runs more often than refleaks for regular-builds): https://buildbot.python.org/#/builders/1226/builds/2352/steps/6/logs/stdio

PR is ready: #122405

encukou commented on Jul 29, 2024

@encukou
Member

My PR #122406 looks exactly the same :)
IMO, it's better to associate the PR with this issue, so the fix-up PR is kept together with the original.

added a commit that references this issue on Jul 29, 2024

picnixz commented on Jul 29, 2024

@picnixz
Member

Closing since the refleak is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions