Skip to content

Skip test_free_threading with GIL #120659

Closed
Closed
Skip test_free_threading with GIL#120659
Labels
topic-free-threadingtype-featureA feature request or enhancement

Description

@nineteendo
nineteendo
opened on Jun 17, 2024

Feature or enhancement

Proposal:

test_free_threading shouldn't run when the GIL is enabled. It takes 2 minutes on the default build, making it the slowest test in the suite.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

Linked PRs

Activity

  1. nineteendo
    added
    type-featureA feature request or enhancement
    on Jun 17, 2024
  2. sobolevn
    added
    topic-free-threading
    on Jun 17, 2024

  3. blhsing commented on Jun 18, 2024

    @blhsing
    blhsing
    on Jun 18, 2024
    Contributor

    test_free_threading shouldn't run when the GIL is disabled.

    I think you mean to say "should only run" rather than "shouldn't run".

  4. vstinner
    added a commit that references this issue on Jun 18, 2024

    gh-120659: Skip `test_freethreading` with GIL (#120660)

    360f14a
  5. miss-islington
    added a commit that references this issue on Jun 18, 2024

    pythongh-120659: Skip `test_freethreading` with GIL (pythonGH-120660)

    1eec326

  6. vstinner commented on Jun 18, 2024

    @vstinner
    vstinner
    on Jun 18, 2024
    Member

    Fixed by 360f14a.

  7. vstinner
    closed this as completedon Jun 18, 2024
  8. vstinner
    added a commit that references this issue on Jun 18, 2024

    [3.13] gh-120659: Skip `test_freethreading` with GIL (GH-120660) (#12…

    4f4973d
  9. picnixz
    added a commit that references this issue on Jun 19, 2024

    pythongh-120659: Skip `test_freethreading` with GIL (python#120660)

    773c86d
  10. mrahtz
    added a commit that references this issue on Jun 30, 2024

    pythongh-120659: Skip `test_freethreading` with GIL (python#120660)

    f6f76d1
  11. noahbkim
    added a commit that references this issue on Jul 11, 2024

    pythongh-120659: Skip `test_freethreading` with GIL (python#120660)

    fed6ee4
  12. estyxx
    added a commit that references this issue on Jul 17, 2024

    pythongh-120659: Skip `test_freethreading` with GIL (python#120660)

    ba3a072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic-free-threadingtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions