Skip to content

Consider marking zip64 tests in test_zipimport as cpu-heavy  #120560

Closed
Closed
Consider marking zip64 tests in test_zipimport as cpu-heavy #120560
Labels
testsTests in the Lib/test dirtype-featureA feature request or enhancement

Description

@Eclips4
Eclips4
opened on Jun 15, 2024

Feature or enhancement

Proposal:

Without testZip64 and testZip64CruftAndComment test_zipimport takes about ~300ms:

./python -m test -q test_zipimport
Using random seed: 4154114933
0:00:00 load avg: 0.02 Run 1 test sequentially in a single process

== Tests result: SUCCESS ==

Total duration: 270 ms
Total tests: run=81 skipped=6
Total test files: run=1/1
Result: SUCCESS

With them, about ~35 seconds:

./python -m test -q test_zipimport
Using random seed: 3529335933
0:00:00 load avg: 0.01 Run 1 test sequentially in a single process
test_zipimport passed in 35.0 sec

== Tests result: SUCCESS ==

Total duration: 35.0 sec
Total tests: run=81 skipped=2
Total test files: run=1/1
Result: SUCCESS

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. Eclips4
    added
    type-featureA feature request or enhancement
    testsTests in the Lib/test dir
    on Jun 15, 2024

  2. nineteendo commented on Jun 15, 2024

    @nineteendo
    nineteendo
    on Jun 15, 2024
    Contributor

    It's one of the 10 slowest tests:

    10 slowest tests:
- test_free_threading: 2 min 42 sec
- test.test_multiprocessing_forkserver.test_processes: 1 min 4 sec
- test.test_multiprocessing_spawn.test_processes: 58.9 sec
- test.test_concurrent_futures.test_wait: 52.2 sec
- test_socket: 46.9 sec
- test.test_multiprocessing_spawn.test_misc: 42.5 sec
- test_regrtest: 41.9 sec
- test_zipimport: 40.5 sec
- test_io: 38.9 sec
- test.test_gdb.test_pretty_print: 38.0 sec
  3. brettcannon
    added a commit that references this issue on Jun 17, 2024

    gh-120560: Mark `zip64` tests in `test_zipimport` as CPU-heavy (GH-12…

    ac37a80
  4. brettcannon
    closed this as completedon Jun 17, 2024
  5. mrahtz
    added a commit that references this issue on Jun 30, 2024

    pythongh-120560: Mark `zip64` tests in `test_zipimport` as CPU-heavy (p…

    9267431
  6. noahbkim
    added a commit that references this issue on Jul 11, 2024

    pythongh-120560: Mark `zip64` tests in `test_zipimport` as CPU-heavy (p…

    e67e31c
  7. estyxx
    added a commit that references this issue on Jul 17, 2024

    pythongh-120560: Mark `zip64` tests in `test_zipimport` as CPU-heavy (p…

    9674a53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsTests in the Lib/test dirtype-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions