Skip to content

Wrap some multi-line macros in do { ... } while(0) in {codegen,compile}.c #120017

Closed

Description

@picnixz

Feature or enhancement

Proposal:

Follow-up from the following observation (I'm sending a PR just after):

There are similar patterns in compile.c, maybe it is also worth taking a look? 🤔

Originally posted by @sobolevn in #119981 (comment)

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. picnixz commented on Jun 4, 2024

    @picnixz
    Author
  2. changed the title [-] Wrap some multi-line macros in `do { ... } while(0)` in `compile.c`[/-] [+] Wrap some multi-line macros in `do { ... } while(0)` in `codegen.c`[/+] on Nov 7, 2024
  3. changed the title [-] Wrap some multi-line macros in `do { ... } while(0)` in `codegen.c`[/-] [+] Wrap some multi-line macros in `do { ... } while(0)` in `{compile,codegen}.c`[/+] on Nov 7, 2024
  4. changed the title [-] Wrap some multi-line macros in `do { ... } while(0)` in `{compile,codegen}.c`[/-] [+] Wrap some multi-line macros in `do { ... } while(0)` in `{codegen,compile}.c`[/+] on Nov 7, 2024
  5. added a commit that references this issue on Nov 7, 2024
  6. picnixz commented on Nov 8, 2024

    @picnixz
    MemberAuthor

    Closing since it was completed. I won't backport it since I didn't backport the others.

  7. added a commit that references this issue on Dec 8, 2024
  8. added a commit that references this issue on Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    interpreter-core(Objects, Python, Grammar, and Parser dirs)type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions