Skip to content

Generalize path_t for C level optimizations #118263

Description

@nineteendo

Feature or enhancement

Proposal:

Quoting @eryksun:

The implementation of path_t could be generalized to support fields to configure the converter to use wide regardless of platform, to allow null characters, to allow arbitrary length paths (e.g. no 32767 length limit on Windows), and a new field such as bytes_input to determine whether a path result has to be converted back to bytes. The option to always use a wide-character path is a generalization of the current behavior on Windows. Argument Clinic would be extended to support the new options. The implementations of _path_splitroot_ex(), _path_normpath(), and _path_abspath() (if adopted) would benefit, and also the _path_is*() helpers on Windows.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

Linked PRs

Activity

  1. nineteendo commented on Apr 25, 2024

    @nineteendo
    ContributorAuthor

    cc @zooba, @serhiy-storchaka Sorry for the ping, I couldn't wait on your response, so I implemented it on my own.

  2. added a commit that references this issue on May 24, 2024
  3. added a commit that references this issue on May 24, 2024
  4. added a commit that references this issue on May 24, 2024
  5. added a commit that references this issue on May 27, 2024
  6. added a commit that references this issue on May 28, 2024
  7. added a commit that references this issue on Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions