You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Prevent non-source files from being added into source-only directories #118189
gh-118159 accidentally added Include/incl.tar with a full copy of Include. Since this addition fell through the cracks, we need to help both contributors and triagers by .gitignore-ing non-source files in the most edited directories:
anything different from *.h in Include
anything different from *.py in Lib (except Lib/test where code is bundled with test data)
Modules and Objects require more complex rules so I skipped them. However, it'll be great if anyone defines and adds them.
I don't think it's worth adding automated rules here. Adding such rules has a cost in that it can cause confusion when a future change relies on adding files that don't match the pattern we expect. And the benefit is low because it's rare that we accidentally add files and if we do, we can easily fix the mistake later.
Activity
JelleZijlstra commentedon Apr 23, 2024
I don't think it's worth adding automated rules here. Adding such rules has a cost in that it can cause confusion when a future change relies on adding files that don't match the pattern we expect. And the benefit is low because it's rare that we accidentally add files and if we do, we can easily fix the mistake later.
gh-118189: Revert accidentally added incl.tar (#118190)