Repository navigation
configparser.DuplicateOptionError leaves ConfigParser instance in bad state #116957
Description
Bug report
Bug description:
If you catch configparser.Error when reading a config file (the intention is to skip invalid config files) and then attempt to use the ConfigParser instance, you can get really weird errors. In the following example, read raises DuplicateOptionError from the 2nd section, but attempting to get a value from the first section fails in the interpolation code, because somehow the value has been stored as a list instead of a string!
>>> import configparser
>>> cp = configparser.ConfigParser()
>>> cp.read_string('[a]\nx=1\n[b]\ny=1\ny=2')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.12/configparser.py", line 710, in read_string
self.read_file(sfile, source)
File "/usr/lib/python3.12/configparser.py", line 705, in read_file
self._read(f, source)
File "/usr/lib/python3.12/configparser.py", line 1074, in _read
raise DuplicateOptionError(sectname, optname,
configparser.DuplicateOptionError: While reading from '<string>' [line 5]: option 'y' in section 'b' already exists
>>> cp.get('a', 'x')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python3.12/configparser.py", line 777, in get
return self._interpolation.before_get(self, section, option, value,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.12/configparser.py", line 367, in before_get
self._interpolate_some(parser, option, L, value, section, defaults, 1)
File "/usr/lib/python3.12/configparser.py", line 384, in _interpolate_some
p = rest.find("%")
^^^^^^^^^
AttributeError: 'list' object has no attribute 'find'Disabling interpolation can read the value from the 1st section but it's a list, not a str!
>>> cp.get('a', 'x', raw=True)
['1']
CPython versions tested on:
3.10, 3.12, CPython main branch
Operating systems tested on:
Linux
Activity
drothlis commentedon Mar 18, 2024
This behaviour is because
ConfigParser._readdoesn't call_join_multiline_valueswhen it raises DuplicateSectionError or DuplicateOptionError (but it does for ParsingError):cpython/Lib/configparser.py
Lines 1059 to 1062 in 43c9d61
pythongh-116957: configparser: Do post-process values after Duplicate…
pythongh-116957: Add NEWS blurb
gh-116957: configparser: Do post-process values after DuplicateOption…
[3.11] pythongh-116957: configparser: Do post-process values after Du…
[3.12] pythongh-116957: configparser: Do post-process values after Du…
[3.12] gh-116957: configparser: Do post-process values after Duplicat…
[3.11] gh-116957: configparser: Do post-process values after Duplicat…
pythongh-116957: configparser: Do post-process values after Duplicate…
pythongh-116957: configparser: Do post-process values after Duplicate…
pythongh-116957: configparser: Do post-process values after Duplicate…