You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Split hot and cold parts of the templates. #116422
Maybe not worth pursuing yet, but just realized: if we make all jumps backwards (meaning, put cold stubs before the entry point) then we can emit the entire thing in one forward pass once we have a slab allocator. But probably more trouble than it's worth right now.
Activity
markshannon commentedon Mar 6, 2024
In order to split out the cold parts of instructions we will need to support jumps within executors.
Something like:
@brandtbucher How much effort to support this in the JIT?
I assume not that much as the prototype must have supported
_POP_JUMP_IF_FALSE.brandtbucher commentedon Mar 6, 2024
Not hard. We already loop once to get the total size before compiling, so collecting offsets during that same step isn't difficult.
brandtbucher commentedon Mar 6, 2024
And yeah, the prototype already did this at one point back when we had exit stubs.
brandtbucher commentedon Mar 6, 2024
Maybe not worth pursuing yet, but just realized: if we make all jumps backwards (meaning, put cold stubs before the entry point) then we can emit the entire thing in one forward pass once we have a slab allocator. But probably more trouble than it's worth right now.
GH-116422: Factor out eval breaker checks at end of calls into its ow…
GH-116422: Modify a few uops so that they can be supported by tier 2 …
pythonGH-116422: Factor out eval breaker checks at end of calls into …
pythonGH-116422: Modify a few uops so that they can be supported by t…
pythonGH-116422: Factor out eval breaker checks at end of calls into …
pythonGH-116422: Modify a few uops so that they can be supported by t…
GH-116422: Tier2 hot/cold splitting (GH-116813)
pythonGH-116422: Tier2 hot/cold splitting (pythonGH-116813)
Squashed commit of the following:
Squashed commit of the following:
pythonGH-116422: Factor out eval breaker checks at end of calls into …
pythonGH-116422: Modify a few uops so that they can be supported by t…
pythonGH-116422: Tier2 hot/cold splitting (pythonGH-116813)