Skip to content

Remove Py_BUILD_CORE_MODULE and Py_BUILD_CORE_MODULE in rotatingtree.c #116181

Description

@aisk

Feature or enhancement

Proposal:

Currently, we require Py_Mutex to isolate the states of pseudo random generator in rotatingtree.c, thus the Py_BUILD_CORE_MODULE was introduced in #115301, but we should refrain from using Py_BUILD_CORE_MODULE or Py_BUILD_CORE_BUILTIN to build non-builtin stdlib modules.

Therefore, we should either remove them once Py_Mutex becomes public or explore alternative solutions to address this issue.

Has this already been discussed elsewhere?

Previous discussion: #115301 (comment)

Links to previous discussion of this feature:

No response

Linked PRs

Activity

  1. ericsnowcurrently commented on Mar 1, 2024

    @ericsnowcurrently
    Member
  2. changed the title [-]Remove `Py_BUILD_CORE_MODULE` and ` in `rotatingtree.c`[/-] [+]Remove `Py_BUILD_CORE_MODULE` and `Py_BUILD_CORE_MODULE` in `rotatingtree.c`[/+] on Mar 2, 2024
  3. added a commit that references this issue on Jul 3, 2024
  4. added a commit that references this issue on Jul 3, 2024
  5. added a commit that references this issue on Jul 3, 2024
  6. added a commit that references this issue on Jul 11, 2024
  7. added a commit that references this issue on Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type-featureA feature request or enhancement

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions