Repository navigation
test_monitoring contains hardcoded line numbers #115836
Description
Bug report
Bug description:
test_lines_single, test_lines_loop, and test_lines_two in test_monitoring.LinesMonitoringTest all contain some hardcoded line numbers in their expected values. They should consistently use offsets from co_firstlineno on the relevant code objects instead.
I ran into this while adding a test for gh-115832, and already have a fix ready to put up as a PR.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Activity
pythongh-115836: Don't use hardcoded line numbers in test_monitoring
gh-115836: Don't use hardcoded line numbers in test_monitoring (#115837)
itamaro commentedon Feb 23, 2024
Fix merged, closing the issue (please reopen if there's more left to do here).
pythongh-115836: Don't use hardcoded line numbers in test_monitoring (p…
pythongh-115836: Don't use hardcoded line numbers in test_monitoring (p…
pythongh-115836: Don't use hardcoded line numbers in test_monitoring (p…