Skip to content

Show number of leaks in --huntrleaks #115720

Closed

Description

@encukou

Feature or enhancement

Currently, -R (--huntrleaks) only displays the reference counts when the test fails. It also uses a generous heuristic, which avoid false positives, but might hide issues.

To get more insight into what's going on, I propose to show the number of leaks instead of the dot, with

  • . instead of 0, so leaks stand out
  • X instead of 10 or more, to keep the display as a single digit

Additionally, I'd like to separate warmup runs, so you know when to start worrying.

The output would look like this:

beginning 9 repetitions. Showing number of leaks (. for zero, X for 10 or more)
12345:6789
XX.1. ....

meaning the first 2 warmups “leaked” a lot, then one more had a single “leak”, and there were no more leaks.

Linked PRs

Activity

  1. added
    type-featureA feature request or enhancement
    testsTests in the Lib/test dir
    on Feb 20, 2024
  2. self-assigned this
    on Feb 20, 2024
  3. added a commit that references this issue on Feb 27, 2024
  4. encukou commented on Feb 27, 2024

    @encukou
    MemberAuthor

    Merged.
    The behaviour is slightly different, to account for negative “leak counts”; for details see af5f9d6. (Or a test run -- the output should be self-descriptive.)

    I plan to leave this in main for a while before deciding about backports.

  5. added a commit that references this issue on Mar 4, 2024
  6. added a commit that references this issue on Mar 25, 2024
  7. added 3 commits that reference this issue on Mar 26, 2024
  8. added a commit that references this issue on Mar 26, 2024
  9. added a commit that references this issue on Mar 26, 2024
  10. added a commit that references this issue on Apr 17, 2024
  11. added a commit that references this issue on Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtype-featureA feature request or enhancement

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions