run_presite's error handling is wrong

Bug report

Lines 1106 to 1113 in 4742047

    
           PyObject *presite_modname = PyUnicode_FromWideChar( 
        
               config->run_presite, 
        
               wcslen(config->run_presite) 
        
           ); 
        
           if (presite_modname == NULL) { 
        
               fprintf(stderr, "Could not convert pre-site module name to unicode\n"); 
        
               Py_DECREF(presite_modname); 
        
           }

I think that Py_DECREF(presite_modname); is not needed, because presite_modname is NULL in this branch.

This will, likely, lead to a crash.
I have a PR ready.

Linked PRs

gh-115503: Fix run_presite error handling #115504

pythongh-115503: Fix `run_presite` error handling

gh-115503: Fix `run_presite` error handling (#115504)

pythongh-115503: Fix `run_presite` error handling (python#115504)

Navigation Menu

Repository navigation

`run_presite`'s error handling is wrong #115503

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	PyObject *presite_modname = PyUnicode_FromWideChar(
	config->run_presite,
	wcslen(config->run_presite)
	);
	if (presite_modname == NULL) {
	fprintf(stderr, "Could not convert pre-site module name to unicode\n");
	Py_DECREF(presite_modname);
	}

run_presite's error handling is wrong #115503

Description

Bug report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`run_presite`'s error handling is wrong #115503