Empty __module__ attribute for built-in static methods

Bug report

Bug description:

An example:

>>> bytes.maketrans.__module__ is None
True

c.f. pure-python staticmethod:

>>> class Spam:
...     @staticmethod
...     def foo():
...         pass
... 
>>> Spam.foo.__module__
'__main__'

I'm not sure, maybe this should be treated rather as a feature request. Docs says about the attribute value: "The name of the module the function was defined in, or None if unavailable." But clearly, this value is available: the type_add_method() has type argument and we could query value of its __module__ attribute.

Edit: BTW, same happens for class methods, e.g.:

>>> int.from_bytes.__module__ is None
True

Probably this should be fixed as well.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs

gh-115231: fill __module__ for built-in staticmethods #115232

pythongh-115231: fill __module__ attribute for built-in staticmethods

pythongh-115231: fill __module__ for built-in class/staticmethods

Revert "pythongh-115231: fill __module__ for built-in class/staticmet…

@vstinner

Built-in static and class methods has different types than static and class methods in Python classes. This is not a bug.

Static and class methods in Python classes started to inherit function attributes only since 3.10 (bpo-43682/gh-87848). cc @vstinner

Static and class methods in Python classes started to inherit function attributes only since 3.10

Hmm, above code snippet works on 3.8+ as well, e.g.:

Python 3.9.19+ (heads/3.9:3f5d9d12c7, Aug 29 2024, 13:17:09) 
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> class Spam:
...     @staticmethod
...     def foo():
...         pass
... 
>>> Spam.foo.__module__
'__main__'
>>>

Static and class methods in Python classes copy attributes from the wrapped methods. But unbound built-in methods do not have the __module__ attribute, so not copying it is okay. On other hand, bound built-in methods have __module__ equal to None:

>>> collections.deque.append.__module__
Traceback (most recent call last):
  File "<python-input-15>", line 1, in <module>
    collections.deque.append.__module__
AttributeError: 'method_descriptor' object has no attribute '__module__'. Did you mean: '__reduce__'?
>>> collections.deque().append.__module__ is None
True

We should first decide whether we need the __module__ attribute for regular builtin methods.

We should first decide whether we need the __module__ attribute for regular builtin methods.

That should be helpful for introspection. E.g. now the inspect._signature_fromstr() resolves module_dict to empty for e.g. bytes.maketrans() or int.from_bytes(). That essentially forbids e.g. using module constants as default values.

gh-115231: Fill __module__ for built-in staticmethods (#115232)

pythongh-115231: Fill __module__ for built-in staticmethods (python#1…

Navigation Menu

Repository navigation

Empty module attribute for built-in static methods #115231

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Empty __module__ attribute for built-in static methods #115231

Description

Bug report

Bug description:

CPython versions tested on:

Operating systems tested on:

Linked PRs

Activity

serhiy-storchaka commented on Nov 2, 2024

skirpichev commented on Nov 2, 2024

serhiy-storchaka commented on Nov 2, 2024

skirpichev commented on Nov 2, 2024

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Empty module attribute for built-in static methods #115231